From: Jonathan Corbet <corbet@lwn.net>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/find-unused-docs: Fix massive false positives
Date: Mon, 27 Jan 2020 14:26:41 -0700 [thread overview]
Message-ID: <20200127142641.6e865467@lwn.net> (raw)
In-Reply-To: <20200127093107.26401-1-geert+renesas@glider.be>
On Mon, 27 Jan 2020 10:31:07 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a
> source file contains kerneldoc or not.
>
> However, as it passes the no longer supported "-text" option to
> scripts/kernel-doc, the latter prints out its help text, causing all
> files to be considered containing kerneldoc.
>
> Get rid of these false positives by removing the no longer supported
> "-text" option from the scripts/kernel-doc invocation.
>
> Fixes: b05142675310d2ac ("scripts: kernel-doc: get rid of unused output formats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Sigh, I guess I should have tried that script before telling people to use
it. Thanks for the fix; I've applied it with a CC: stable tag.
jon
prev parent reply other threads:[~2020-01-27 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 9:31 Geert Uytterhoeven
2020-01-27 21:26 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127142641.6e865467@lwn.net \
--to=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=jani.nikula@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®