mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: rectify radix-tree testing entry in XARRAY
@ 2020-02-01 18:02 Lukas Bulwahn
  2020-02-01 21:35 ` Lukas Bulwahn
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2020-02-01 18:02 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: linux-fsdevel, linux-kernel, Lukas Bulwahn

The initial commit 3d5bd6e1a04a ("xarray: Add MAINTAINERS entry")
missed a trailing slash to include all files and subdirectory files.
Hence, all files in tools/testing/radix-tree were not part of XARRAY,
but were considered to be part of "THE REST".

Rectify this to ensure patches reach the actual maintainer.

This was identified with a small script that finds all files only
belonging to "THE REST" according to the current MAINTAINERS file, and I
acted upon its output.

Fixes: 3d5bd6e1a04a ("xarray: Add MAINTAINERS entry")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Matthew, please pick this small fixup patch.

applies cleanly on current master and next-20200131

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1f77fb8cdde3..4ebcc2f09028 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18198,7 +18198,7 @@ F:	lib/idr.c
 F:	lib/xarray.c
 F:	include/linux/idr.h
 F:	include/linux/xarray.h
-F:	tools/testing/radix-tree
+F:	tools/testing/radix-tree/
 
 XBOX DVD IR REMOTE
 M:	Benjamin Valentin <benpicco@googlemail.com>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify radix-tree testing entry in XARRAY
  2020-02-01 18:02 [PATCH] MAINTAINERS: rectify radix-tree testing entry in XARRAY Lukas Bulwahn
@ 2020-02-01 21:35 ` Lukas Bulwahn
  2020-02-01 23:35   ` Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2020-02-01 21:35 UTC (permalink / raw)
  To: Lukas Bulwahn; +Cc: Matthew Wilcox, linux-fsdevel, linux-kernel, Joe Perches



On Sat, 1 Feb 2020, Lukas Bulwahn wrote:

> The initial commit 3d5bd6e1a04a ("xarray: Add MAINTAINERS entry")
> missed a trailing slash to include all files and subdirectory files.
> Hence, all files in tools/testing/radix-tree were not part of XARRAY,
> but were considered to be part of "THE REST".
> 
> Rectify this to ensure patches reach the actual maintainer.
> 
> This was identified with a small script that finds all files only
> belonging to "THE REST" according to the current MAINTAINERS file, and I
> acted upon its output.
> 
> Fixes: 3d5bd6e1a04a ("xarray: Add MAINTAINERS entry")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Matthew, please pick this small fixup patch.
> 
> applies cleanly on current master and next-20200131
> 

Matthew, Joe Perches just informed me that get_maintainers.pl is smart
enough to handle the case below and does not strictly need a further 
trailing slash.

Please ignore this patch; the commit message is actually wrong.

Lukas

>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1f77fb8cdde3..4ebcc2f09028 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18198,7 +18198,7 @@ F:	lib/idr.c
>  F:	lib/xarray.c
>  F:	include/linux/idr.h
>  F:	include/linux/xarray.h
> -F:	tools/testing/radix-tree
> +F:	tools/testing/radix-tree/
>  
>  XBOX DVD IR REMOTE
>  M:	Benjamin Valentin <benpicco@googlemail.com>
> -- 
> 2.17.1
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify radix-tree testing entry in XARRAY
  2020-02-01 21:35 ` Lukas Bulwahn
@ 2020-02-01 23:35   ` Joe Perches
  0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-02-01 23:35 UTC (permalink / raw)
  To: Lukas Bulwahn; +Cc: Matthew Wilcox, linux-fsdevel, linux-kernel

On Sat, 2020-02-01 at 22:35 +0100, Lukas Bulwahn wrote:
> 
> On Sat, 1 Feb 2020, Lukas Bulwahn wrote:
> 
> > The initial commit 3d5bd6e1a04a ("xarray: Add MAINTAINERS entry")
> > missed a trailing slash to include all files and subdirectory files.
> > Hence, all files in tools/testing/radix-tree were not part of XARRAY,
> > but were considered to be part of "THE REST".
> > 
> > Rectify this to ensure patches reach the actual maintainer.
> > 
> > This was identified with a small script that finds all files only
> > belonging to "THE REST" according to the current MAINTAINERS file, and I
> > acted upon its output.
> > 
> > Fixes: 3d5bd6e1a04a ("xarray: Add MAINTAINERS entry")
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > Matthew, please pick this small fixup patch.
> > 
> > applies cleanly on current master and next-20200131
> > 
> 
> Matthew, Joe Perches just informed me that get_maintainers.pl is smart
> enough to handle the case below and does not strictly need a further 
> trailing slash.
> 
> Please ignore this patch; the commit message is actually wrong.

While the commit message may be inexact,
I think the actual change is good and
could/should still be applied.

The "Fixes:" tag is unnecessary though.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-01 23:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-01 18:02 [PATCH] MAINTAINERS: rectify radix-tree testing entry in XARRAY Lukas Bulwahn
2020-02-01 21:35 ` Lukas Bulwahn
2020-02-01 23:35   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®