From: Mark Brown <broonie@kernel.org>
To: Rishi Gupta <gupt21@gmail.com>
Cc: support.opensource@diasemi.com,
Adam.Thomson.Opensource@diasemi.com, axel.lin@ingics.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: da9063: remove redundant return statement
Date: Thu, 6 Feb 2020 11:32:48 +0000 [thread overview]
Message-ID: <20200206113248.GL3897@sirena.org.uk> (raw)
In-Reply-To: <1580963761-24964-1-git-send-email-gupt21@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Thu, Feb 06, 2020 at 10:06:01AM +0530, Rishi Gupta wrote:
> The devm_request_threaded_irq() already returns 0 on success
> and negative error code on failure. So return from this itself
> can be used while preserving error log in case of failure.
>
> This commit also fixes checkpatch.pl errors & warnings:
> - WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> - WARNING: line over 80 characters
> - ERROR: space prohibited before that ',' (ctx:WxW)
> - ERROR: code indent should use tabs where possible
> - WARNING: Block comments use * on subsequent lines
This should be split into separate patches, each doing one thing
as covered in submitting-patchs.rst.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-06 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 4:36 Rishi Gupta
2020-02-06 11:32 ` Mark Brown [this message]
2020-02-06 13:50 ` rishi gupta
2020-02-06 13:49 Rishi Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206113248.GL3897@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=axel.lin@ingics.com \
--cc=gupt21@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®