[PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

[PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

[Andy Shevchenko]

Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 211043d91cd0..4791757ba1ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17932,11 +17932,11 @@ M:	Steven Rostedt <rostedt@goodmis.org>
 M:	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
 R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
 R:	Rasmus Villemoes <linux@rasmusvillemoes.dk>
-T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
 S:	Maintained
-F:	lib/vsprintf.c
-F:	lib/test_printf.c
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
 F:	Documentation/core-api/printk-formats.rst
+F:	lib/test_printf.c
+F:	lib/vsprintf.c
 
 VT1211 HARDWARE MONITOR DRIVER
 M:	Juerg Haefliger <juergh@gmail.com>
-- 
2.24.1

Re: [PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

[Petr Mladek]

Hi Andy,

On Tue 2020-01-28 16:34:25, Andy Shevchenko wrote:
> Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.

Does this produce any visible error or warning anywhere, please?

checkpatch.pl does not warn about it.

Also the order does not look defined in the file. When I run
parse-maintainers.pl on the entire MAINTAINERS file:

 MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
 1 file changed, 2787 insertions(+), 2797 deletions(-)

The file has 18545 lines. It means that huge amount of entries
do not follow the order.

Best Regards,
Petr

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 211043d91cd0..4791757ba1ef 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17932,11 +17932,11 @@ M:	Steven Rostedt <rostedt@goodmis.org>
>  M:	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>  R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>  R:	Rasmus Villemoes <linux@rasmusvillemoes.dk>
> -T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
>  S:	Maintained
> -F:	lib/vsprintf.c
> -F:	lib/test_printf.c
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
>  F:	Documentation/core-api/printk-formats.rst
> +F:	lib/test_printf.c
> +F:	lib/vsprintf.c
>  
>  VT1211 HARDWARE MONITOR DRIVER
>  M:	Juerg Haefliger <juergh@gmail.com>
> -- 
> 2.24.1

Re: [PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

[Andy Shevchenko]

On Mon, Feb 10, 2020 at 03:21:55PM +0100, Petr Mladek wrote:
> Hi Andy,
> 
> On Tue 2020-01-28 16:34:25, Andy Shevchenko wrote:
> > Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.
> 
> Does this produce any visible error or warning anywhere, please?

Not for the moment.
Nevertheless, there is an initial motivation behind this [1,2].


> checkpatch.pl does not warn about it.
> 
> Also the order does not look defined in the file. When I run
> parse-maintainers.pl on the entire MAINTAINERS file:

See [2] for the details.

>  MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
>  1 file changed, 2787 insertions(+), 2797 deletions(-)
> 
> The file has 18545 lines. It means that huge amount of entries
> do not follow the order.

Yes, but it's getting better.

[1]: 7683e9e52925 ("Properly alphabetize MAINTAINERS file")
[2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com/

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

[Andy Shevchenko]

On Mon, Feb 10, 2020 at 04:51:29PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 10, 2020 at 03:21:55PM +0100, Petr Mladek wrote:

> > Also the order does not look defined in the file. When I run
> > parse-maintainers.pl on the entire MAINTAINERS file:
> 
> See [2] for the details.

"... But in the meantime, at least that MAINTAINERS file should _really_ be
alpha-sorted now."

> [2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com/

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

[Petr Mladek]

On Mon 2020-02-10 16:51:29, Andy Shevchenko wrote:
> On Mon, Feb 10, 2020 at 03:21:55PM +0100, Petr Mladek wrote:
> > Hi Andy,
> > 
> > On Tue 2020-01-28 16:34:25, Andy Shevchenko wrote:
> > > Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.
> > 
> > Also the order does not look defined in the file. When I run
> > parse-maintainers.pl on the entire MAINTAINERS file:
> 
> See [2] for the details.
> 
> >  MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
> >  1 file changed, 2787 insertions(+), 2797 deletions(-)
> > 
> > The file has 18545 lines. It means that huge amount of entries
> > do not follow the order.
> 
> Yes, but it's getting better.
> 
> [1]: 7683e9e52925 ("Properly alphabetize MAINTAINERS file")
> [2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com/

Ok, the message [2] is Linus' reaction on a similar patch.
He complained that

 (a) the ordering wasn't complete
 (b) this wasn't scripted.

In fact, parse-maintainers.pl was created to automatize such clean ups
and allow to fix all entries at once.

Fixing only VSPRITF record is a tiny-piece-by-piece approach.
It is an approach that will create a lot of work for many people.

If you want to do a clean up then please ask Linus to do it by the
script.

Also please add a check into checkpatch.pl to reduce regressions.

Best Regards,
Petr