From: Josh Poimboeuf <jpoimboe@redhat.com>
To: tip-bot2 for Josh Poimboeuf <tip-bot2@linutronix.de>
Cc: linux-tip-commits@vger.kernel.org, Borislav Petkov <bp@suse.de>,
Julien Thierry <jthierry@redhat.com>, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [tip: core/objtool] objtool: Fail the kernel build on fatal errors
Date: Thu, 13 Feb 2020 16:11:00 -0600 [thread overview]
Message-ID: <20200213221100.odwg5gan3dwcpk6g@treble> (raw)
In-Reply-To: <158142525822.411.5401976987070210798.tip-bot2@tip-bot2>
On Tue, Feb 11, 2020 at 12:47:38PM -0000, tip-bot2 for Josh Poimboeuf wrote:
> The following commit has been merged into the core/objtool branch of tip:
>
> Commit-ID: 644592d328370af4b3e027b7b1ae9f81613782d8
> Gitweb: https://git.kernel.org/tip/644592d328370af4b3e027b7b1ae9f81613782d8
> Author: Josh Poimboeuf <jpoimboe@redhat.com>
> AuthorDate: Mon, 10 Feb 2020 12:32:38 -06:00
> Committer: Borislav Petkov <bp@suse.de>
> CommitterDate: Tue, 11 Feb 2020 13:27:03 +01:00
>
> objtool: Fail the kernel build on fatal errors
>
> When objtool encounters a fatal error, it usually means the binary is
> corrupt or otherwise broken in some way. Up until now, such errors were
> just treated as warnings which didn't fail the kernel build.
>
> However, objtool is now stable enough that if a fatal error is
> discovered, it most likely means something is seriously wrong and it
> should fail the kernel build.
>
> Note that this doesn't apply to "normal" objtool warnings; only fatal
> ones.
Clang still has some toolchain issues which need to be sorted out, so
upgrading the fatal errors is causing their CI to fail.
So I think we need to drop this one for now.
Boris, are you able to just drop it or should I send a revert?
--
Josh
next prev parent reply other threads:[~2020-02-13 22:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 18:32 [PATCH 0/3] objtool: Relocation sanity check for alternatives Josh Poimboeuf
2020-02-10 18:32 ` [PATCH 1/3] objtool: Fail the kernel build on fatal errors Josh Poimboeuf
2020-02-11 7:51 ` Julien Thierry
2020-02-11 12:47 ` [tip: core/objtool] " tip-bot2 for Josh Poimboeuf
2020-02-13 22:11 ` Josh Poimboeuf [this message]
2020-02-14 0:10 ` Thomas Gleixner
2020-02-14 17:57 ` Josh Poimboeuf
2020-02-19 22:43 ` Nick Desaulniers
2020-02-20 0:44 ` Philip Li
2020-02-20 19:09 ` Nick Desaulniers
2020-02-10 18:32 ` [PATCH 2/3] objtool: Add is_static_jump() helper Josh Poimboeuf
2020-02-11 7:52 ` Julien Thierry
2020-02-11 12:47 ` [tip: core/objtool] " tip-bot2 for Josh Poimboeuf
2020-02-10 18:32 ` [PATCH 3/3] objtool: Add relocation check for alternative sections Josh Poimboeuf
2020-02-11 1:51 ` Linus Torvalds
2020-02-11 8:47 ` Borislav Petkov
2020-02-11 8:16 ` Julien Thierry
2020-02-11 12:47 ` [tip: core/objtool] " tip-bot2 for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213221100.odwg5gan3dwcpk6g@treble \
--to=jpoimboe@redhat.com \
--cc=bp@suse.de \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tip-bot2@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®