mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: manivannan.sadhasivam@linaro.org
Cc: kuba@kernel.org, bjorn.andersson@linaro.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace
Date: Sun, 16 Feb 2020 18:56:00 -0800 (PST)	[thread overview]
Message-ID: <20200216.185600.43507558643527863.davem@davemloft.net> (raw)
In-Reply-To: <20200213091427.13435-2-manivannan.sadhasivam@linaro.org>

From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date: Thu, 13 Feb 2020 14:44:26 +0530

> +static int service_announce_new(struct sockaddr_qrtr *dest,
> +				struct qrtr_server *srv)
> +{
> +	struct qrtr_ctrl_pkt pkt;
> +	struct msghdr msg = { };
> +	struct kvec iv = { &pkt, sizeof(pkt) };

Please use reverse christmas tree ordering for local variables.

Please fix this for your entire submission.

  reply	other threads:[~2020-02-17  2:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  9:14 [PATCH 0/2] Migrate QRTR Nameservice to Kernel Manivannan Sadhasivam
2020-02-13  9:14 ` [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace Manivannan Sadhasivam
2020-02-17  2:56   ` David Miller [this message]
2020-06-16 18:48   ` Qais Yousef
2020-06-19 14:46     ` Manivannan Sadhasivam
2020-06-19 15:03       ` Qais Yousef
2020-02-13  9:14 ` [PATCH 2/2] net: qrtr: Fix the local node ID as 1 Manivannan Sadhasivam
2020-02-13 15:22 ` [PATCH 0/2] Migrate QRTR Nameservice to Kernel Dan Williams
2020-02-13 15:30   ` Manivannan Sadhasivam
2020-02-13 15:47     ` David Miller
2020-02-14  7:08       ` Manivannan Sadhasivam
2020-02-14  9:11       ` Manivannan Sadhasivam
2020-02-16 15:52         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200216.185600.43507558643527863.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bjorn.andersson@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®