From: Qais Yousef <qais.yousef@arm.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace
Date: Tue, 16 Jun 2020 19:48:06 +0100 [thread overview]
Message-ID: <20200616184805.k7eowfhdevasqite@e107158-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200213091427.13435-2-manivannan.sadhasivam@linaro.org>
Hi Manivannan, David
On 02/13/20 14:44, Manivannan Sadhasivam wrote:
[...]
> + trace_printk("advertising new server [%d:%x]@[%d:%d]\n",
> + srv->service, srv->instance, srv->node, srv->port);
I can't tell exactly from the discussion whether this is the version that got
merged into 5.7 or not, but it does match the commit message.
This patch introduces several trace_printk() which AFAIK is intended for
debugging only and shouldn't make it into mainline kernels.
It causes this big message to be printed to the log too
[ 0.000000] **********************************************************
[ 0.000000] ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **
[ 0.000000] ** **
[ 0.000000] ** trace_printk() being used. Allocating extra memory. **
[ 0.000000] ** **
[ 0.000000] ** This means that this is a DEBUG kernel and it is **
[ 0.000000] ** unsafe for production use. **
[ 0.000000] ** **
[ 0.000000] ** If you see this message and you are not debugging **
[ 0.000000] ** the kernel, report this immediately to your vendor! **
[ 0.000000] ** **
[ 0.000000] ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **
[ 0.000000] **********************************************************
Shouldn't this be replaced with one of pr_*() variants instead?
Thanks
--
Qais Yousef
next prev parent reply other threads:[~2020-06-16 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 9:14 [PATCH 0/2] Migrate QRTR Nameservice to Kernel Manivannan Sadhasivam
2020-02-13 9:14 ` [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace Manivannan Sadhasivam
2020-02-17 2:56 ` David Miller
2020-06-16 18:48 ` Qais Yousef [this message]
2020-06-19 14:46 ` Manivannan Sadhasivam
2020-06-19 15:03 ` Qais Yousef
2020-02-13 9:14 ` [PATCH 2/2] net: qrtr: Fix the local node ID as 1 Manivannan Sadhasivam
2020-02-13 15:22 ` [PATCH 0/2] Migrate QRTR Nameservice to Kernel Dan Williams
2020-02-13 15:30 ` Manivannan Sadhasivam
2020-02-13 15:47 ` David Miller
2020-02-14 7:08 ` Manivannan Sadhasivam
2020-02-14 9:11 ` Manivannan Sadhasivam
2020-02-16 15:52 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616184805.k7eowfhdevasqite@e107158-lin.cambridge.arm.com \
--to=qais.yousef@arm.com \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®