From: Masami Hiramatsu <mhiramat@kernel.org>
To: Qiujun Huang <hqjagain@gmail.com>
Cc: akpm@linux-foundation.org, mhiramat@kernel.org,
rostedt@goodmis.org, keescook@chromium.org, rppt@linux.ibm.com,
linux@dominikbrodowski.net, nivedita@alum.mit.edu,
nadav.amit@gmail.com, glider@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/main.c: mark boot_config_checksum static
Date: Sun, 16 Feb 2020 21:03:33 +0900 [thread overview]
Message-ID: <20200216210333.b5e911feafb3acfae4a1b89b@kernel.org> (raw)
In-Reply-To: <1581852511-14163-1-git-send-email-hqjagain@gmail.com>
On Sun, 16 Feb 2020 19:28:31 +0800
Qiujun Huang <hqjagain@gmail.com> wrote:
> In fact, this function is only used in this file, so mark it with 'static'.
Good catch!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
>
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index f95b014..534589f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -335,7 +335,7 @@ static char * __init xbc_make_cmdline(const char *key)
> return new_cmdline;
> }
>
> -u32 boot_config_checksum(unsigned char *p, u32 size)
> +static u32 boot_config_checksum(unsigned char *p, u32 size)
> {
> u32 ret = 0;
>
> --
> 1.8.3.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-02-16 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 11:28 Qiujun Huang
2020-02-16 12:03 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216210333.b5e911feafb3acfae4a1b89b@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=hqjagain@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=nadav.amit@gmail.com \
--cc=nivedita@alum.mit.edu \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome