* [PATCH] init/main.c: mark boot_config_checksum static
@ 2020-02-16 11:28 Qiujun Huang
2020-02-16 12:03 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Qiujun Huang @ 2020-02-16 11:28 UTC (permalink / raw)
To: akpm
Cc: mhiramat, rostedt, keescook, rppt, linux, nivedita, nadav.amit,
glider, linux-kernel, Qiujun Huang
In fact, this function is only used in this file, so mark it with 'static'.
Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
---
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/main.c b/init/main.c
index f95b014..534589f 100644
--- a/init/main.c
+++ b/init/main.c
@@ -335,7 +335,7 @@ static char * __init xbc_make_cmdline(const char *key)
return new_cmdline;
}
-u32 boot_config_checksum(unsigned char *p, u32 size)
+static u32 boot_config_checksum(unsigned char *p, u32 size)
{
u32 ret = 0;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] init/main.c: mark boot_config_checksum static
2020-02-16 11:28 [PATCH] init/main.c: mark boot_config_checksum static Qiujun Huang
@ 2020-02-16 12:03 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2020-02-16 12:03 UTC (permalink / raw)
To: Qiujun Huang
Cc: akpm, mhiramat, rostedt, keescook, rppt, linux, nivedita,
nadav.amit, glider, linux-kernel
On Sun, 16 Feb 2020 19:28:31 +0800
Qiujun Huang <hqjagain@gmail.com> wrote:
> In fact, this function is only used in this file, so mark it with 'static'.
Good catch!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
>
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index f95b014..534589f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -335,7 +335,7 @@ static char * __init xbc_make_cmdline(const char *key)
> return new_cmdline;
> }
>
> -u32 boot_config_checksum(unsigned char *p, u32 size)
> +static u32 boot_config_checksum(unsigned char *p, u32 size)
> {
> u32 ret = 0;
>
> --
> 1.8.3.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-16 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-16 11:28 [PATCH] init/main.c: mark boot_config_checksum static Qiujun Huang
2020-02-16 12:03 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome