* [PATCH 4/4] flow_table.c: Use built-in RCU list checking
@ 2020-02-18 19:58 madhuparnabhowmik10
2020-02-18 20:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: madhuparnabhowmik10 @ 2020-02-18 19:58 UTC (permalink / raw)
To: pshelar, davem
Cc: netdev, dev, linux-kernel, joel, frextrite, linux-kernel-mentees,
paulmck, Madhuparna Bhowmik
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
hlist_for_each_entry_rcu() has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu() to silence
false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
by default.
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
net/openvswitch/flow_table.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
index 5904e93e5765..fd8a01ca7a2d 100644
--- a/net/openvswitch/flow_table.c
+++ b/net/openvswitch/flow_table.c
@@ -585,7 +585,8 @@ static struct sw_flow *masked_flow_lookup(struct table_instance *ti,
head = find_bucket(ti, hash);
(*n_mask_hit)++;
- hlist_for_each_entry_rcu(flow, head, flow_table.node[ti->node_ver]) {
+ hlist_for_each_entry_rcu(flow, head, flow_table.node[ti->node_ver],
+ lockdep_ovsl_is_held()) {
if (flow->mask == mask && flow->flow_table.hash == hash &&
flow_cmp_masked_key(flow, &masked_key, &mask->range))
return flow;
@@ -769,7 +770,8 @@ struct sw_flow *ovs_flow_tbl_lookup_ufid(struct flow_table *tbl,
hash = ufid_hash(ufid);
head = find_bucket(ti, hash);
- hlist_for_each_entry_rcu(flow, head, ufid_table.node[ti->node_ver]) {
+ hlist_for_each_entry_rcu(flow, head, ufid_table.node[ti->node_ver],
+ lockdep_ovsl_is_held()) {
if (flow->ufid_table.hash == hash &&
ovs_flow_cmp_ufid(flow, ufid))
return flow;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 4/4] flow_table.c: Use built-in RCU list checking
2020-02-18 19:58 [PATCH 4/4] flow_table.c: Use built-in RCU list checking madhuparnabhowmik10
@ 2020-02-18 20:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-18 20:46 UTC (permalink / raw)
To: madhuparnabhowmik10
Cc: pshelar, netdev, dev, linux-kernel, joel, frextrite,
linux-kernel-mentees, paulmck
From: madhuparnabhowmik10@gmail.com
Date: Wed, 19 Feb 2020 01:28:20 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> hlist_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-18 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 19:58 [PATCH 4/4] flow_table.c: Use built-in RCU list checking madhuparnabhowmik10
2020-02-18 20:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®