[PATCH] phy: core: Fix phy_get() to not return error on link creation failure

[PATCH] phy: core: Fix phy_get() to not return error on link creation failure

[Kishon Vijay Abraham I]

commit 987351e1ea77 ("phy: core: Add consumer device link support")
added device link support between PHY consumer and PHY provider.
However certain peripherals (DWC3 ULPI) have cyclic dependency
between the PHY provider and PHY consumer causing the device link
creation to fail.

Instead of erroring out on failure to create device link, only add a
debug print to indicate device link creation failed to get USB
working again in multiple platforms.

Fixes: 987351e1ea77 ("phy: core: Add consumer device link support")
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/phy-core.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index cd5a6c95dbdc..a27b8d578d7f 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -688,11 +688,9 @@ struct phy *phy_get(struct device *dev, const char *string)
 	get_device(&phy->dev);
 
 	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
-	if (!link) {
-		dev_err(dev, "failed to create device link to %s\n",
+	if (!link)
+		dev_dbg(dev, "failed to create device link to %s\n",
 			dev_name(phy->dev.parent));
-		return ERR_PTR(-EINVAL);
-	}
 
 	return phy;
 }
@@ -803,11 +801,9 @@ struct phy *devm_of_phy_get(struct device *dev, struct device_node *np,
 	}
 
 	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
-	if (!link) {
-		dev_err(dev, "failed to create device link to %s\n",
+	if (!link)
+		dev_dbg(dev, "failed to create device link to %s\n",
 			dev_name(phy->dev.parent));
-		return ERR_PTR(-EINVAL);
-	}
 
 	return phy;
 }
@@ -852,11 +848,9 @@ struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,
 	devres_add(dev, ptr);
 
 	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
-	if (!link) {
-		dev_err(dev, "failed to create device link to %s\n",
+	if (!link)
+		dev_dbg(dev, "failed to create device link to %s\n",
 			dev_name(phy->dev.parent));
-		return ERR_PTR(-EINVAL);
-	}
 
 	return phy;
 }
-- 
2.17.1

Re: [PATCH] phy: core: Fix phy_get() to not return error on link creation failure

[Alexandre Torgue]

Hi Kishon

On 2/18/20 1:14 PM, Kishon Vijay Abraham I wrote:
> commit 987351e1ea77 ("phy: core: Add consumer device link support")
> added device link support between PHY consumer and PHY provider.
> However certain peripherals (DWC3 ULPI) have cyclic dependency
> between the PHY provider and PHY consumer causing the device link
> creation to fail.
> 
> Instead of erroring out on failure to create device link, only add a
> debug print to indicate device link creation failed to get USB
> working again in multiple platforms.
> 
> Fixes: 987351e1ea77 ("phy: core: Add consumer device link support")
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---

I was close to send it also :). Thanks for it.

Reviewed-by: Alexandre TORGUE <alexandre.torgue@st.com>

Thanks
Alex

>   drivers/phy/phy-core.c | 18 ++++++------------
>   1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index cd5a6c95dbdc..a27b8d578d7f 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -688,11 +688,9 @@ struct phy *phy_get(struct device *dev, const char *string)
>   	get_device(&phy->dev);
>   
>   	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
> -	if (!link) {
> -		dev_err(dev, "failed to create device link to %s\n",
> +	if (!link)
> +		dev_dbg(dev, "failed to create device link to %s\n",
>   			dev_name(phy->dev.parent));
> -		return ERR_PTR(-EINVAL);
> -	}
>   
>   	return phy;
>   }
> @@ -803,11 +801,9 @@ struct phy *devm_of_phy_get(struct device *dev, struct device_node *np,
>   	}
>   
>   	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
> -	if (!link) {
> -		dev_err(dev, "failed to create device link to %s\n",
> +	if (!link)
> +		dev_dbg(dev, "failed to create device link to %s\n",
>   			dev_name(phy->dev.parent));
> -		return ERR_PTR(-EINVAL);
> -	}
>   
>   	return phy;
>   }
> @@ -852,11 +848,9 @@ struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,
>   	devres_add(dev, ptr);
>   
>   	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
> -	if (!link) {
> -		dev_err(dev, "failed to create device link to %s\n",
> +	if (!link)
> +		dev_dbg(dev, "failed to create device link to %s\n",
>   			dev_name(phy->dev.parent));
> -		return ERR_PTR(-EINVAL);
> -	}
>   
>   	return phy;
>   }
>