From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4] leds: add SGI IP30 led support
Date: Sat, 22 Feb 2020 11:05:45 +0100 [thread overview]
Message-ID: <20200222110545.fc96683543cb0dd538e5be82@suse.de> (raw)
In-Reply-To: <49524a9a-910a-9f1a-bc10-d78080a16d46@gmail.com>
On Fri, 21 Feb 2020 21:31:04 +0100
Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
> > + if (num == 0)
> > + data->cdev.name = "white:indicator";
> > + else
> > + data->cdev.name = "red:indicator";
>
> Why indicator? Whereas it sounds quite generic it is used in the LED
> subsystem specifically for naming indicator LEDs, that are often
> found on flash LED controllers and are designed to indicate camera
> sensor activity.
ok, ic.
> If it is on the front panel of SGI Octane workstations then its
> function is perhaps well known?
the red LED is clearly a fault led. The white LED will be switch on
after system diagnostic was successfull. Nothing from common.h really
fits that, maybe status ?
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-02-22 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 11:11 Thomas Bogendoerfer
2020-02-21 20:31 ` Jacek Anaszewski
2020-02-22 10:05 ` Thomas Bogendoerfer [this message]
2020-02-22 16:36 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222110545.fc96683543cb0dd538e5be82@suse.de \
--to=tbogendoerfer@suse.de \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®