* [PATCH v2] arm64: dts: sun50i-h5-orange-pi-pc2: Add CPUX voltage regulator
@ 2020-02-23 10:40 Ondrej Jirman
2020-02-24 9:27 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Ondrej Jirman @ 2020-02-23 10:40 UTC (permalink / raw)
To: linux-sunxi
Cc: Ondrej Jirman, Samuel Holland, Maxime Ripard, Chen-Yu Tsai,
Rob Herring, Mark Rutland,
moderated list:ARM/Allwinner sunXi SoC support,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Orange Pi PC2 features sy8106a regulator just like Orange Pi PC.
Signed-off-by: Ondrej Jirman <megous@megous.com>
Reviewed-by: Samuel Holland <samuel@sholland.org>
---
.../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
index 70b5f09984218..7b2572dc84857 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
@@ -93,6 +93,10 @@ &codec {
status = "okay";
};
+&cpu0 {
+ cpu-supply = <®_vdd_cpux>;
+};
+
&de {
status = "okay";
};
@@ -168,6 +172,22 @@ &ohci3 {
status = "okay";
};
+&r_i2c {
+ status = "okay";
+
+ reg_vdd_cpux: regulator@65 {
+ compatible = "silergy,sy8106a";
+ reg = <0x65>;
+ regulator-name = "vdd-cpux";
+ silergy,fixed-microvolt = <1100000>;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-ramp-delay = <200>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+};
+
&spi0 {
status = "okay";
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: sun50i-h5-orange-pi-pc2: Add CPUX voltage regulator
2020-02-23 10:40 [PATCH v2] arm64: dts: sun50i-h5-orange-pi-pc2: Add CPUX voltage regulator Ondrej Jirman
@ 2020-02-24 9:27 ` Maxime Ripard
2020-02-24 15:11 ` Ondřej Jirman
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2020-02-24 9:27 UTC (permalink / raw)
To: Ondrej Jirman
Cc: linux-sunxi, Samuel Holland, Chen-Yu Tsai, Rob Herring,
Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
On Sun, Feb 23, 2020 at 11:40:19AM +0100, Ondrej Jirman wrote:
> Orange Pi PC2 features sy8106a regulator just like Orange Pi PC.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> Reviewed-by: Samuel Holland <samuel@sholland.org>
> ---
> .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
Having a changelog would be great
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> index 70b5f09984218..7b2572dc84857 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> @@ -93,6 +93,10 @@ &codec {
> status = "okay";
> };
>
> +&cpu0 {
> + cpu-supply = <®_vdd_cpux>;
> +};
> +
> &de {
> status = "okay";
> };
> @@ -168,6 +172,22 @@ &ohci3 {
> status = "okay";
> };
>
> +&r_i2c {
> + status = "okay";
> +
> + reg_vdd_cpux: regulator@65 {
> + compatible = "silergy,sy8106a";
> + reg = <0x65>;
> + regulator-name = "vdd-cpux";
> + silergy,fixed-microvolt = <1100000>;
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1400000>;
> + regulator-ramp-delay = <200>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +};
> +
Looks like you fixed the issues reported by Samuel though. I've
applied it.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: sun50i-h5-orange-pi-pc2: Add CPUX voltage regulator
2020-02-24 9:27 ` Maxime Ripard
@ 2020-02-24 15:11 ` Ondřej Jirman
0 siblings, 0 replies; 3+ messages in thread
From: Ondřej Jirman @ 2020-02-24 15:11 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-sunxi, Samuel Holland, Chen-Yu Tsai, Rob Herring,
Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Mon, Feb 24, 2020 at 10:27:04AM +0100, Maxime Ripard wrote:
> On Sun, Feb 23, 2020 at 11:40:19AM +0100, Ondrej Jirman wrote:
> > Orange Pi PC2 features sy8106a regulator just like Orange Pi PC.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > Reviewed-by: Samuel Holland <samuel@sholland.org>
> > ---
> > .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
>
> Having a changelog would be great
>
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> > index 70b5f09984218..7b2572dc84857 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> > @@ -93,6 +93,10 @@ &codec {
> > status = "okay";
> > };
> >
> > +&cpu0 {
> > + cpu-supply = <®_vdd_cpux>;
> > +};
> > +
> > &de {
> > status = "okay";
> > };
> > @@ -168,6 +172,22 @@ &ohci3 {
> > status = "okay";
> > };
> >
> > +&r_i2c {
> > + status = "okay";
> > +
> > + reg_vdd_cpux: regulator@65 {
> > + compatible = "silergy,sy8106a";
> > + reg = <0x65>;
> > + regulator-name = "vdd-cpux";
> > + silergy,fixed-microvolt = <1100000>;
> > + regulator-min-microvolt = <1000000>;
> > + regulator-max-microvolt = <1400000>;
> > + regulator-ramp-delay = <200>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +};
> > +
>
> Looks like you fixed the issues reported by Samuel though. I've
> applied it.
Sorry, yes, I just did that. Re-ordering + removing a comment and changing the
fixed voltage.
Thank you,
o.
> Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-24 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-23 10:40 [PATCH v2] arm64: dts: sun50i-h5-orange-pi-pc2: Add CPUX voltage regulator Ondrej Jirman
2020-02-24 9:27 ` Maxime Ripard
2020-02-24 15:11 ` Ondřej Jirman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®