mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Brian Gerst <brgerst@gmail.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Andy Lutomirski <luto@kernel.org>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Brian Gerst <brgerst@gmail.com>
Subject: [PATCH v2 4/8] x86, syscalls: Refactor SYS_NI macros
Date: Mon, 24 Feb 2020 13:17:53 -0500	[thread overview]
Message-ID: <20200224181757.724961-5-brgerst@gmail.com> (raw)
In-Reply-To: <20200224181757.724961-1-brgerst@gmail.com>

Pull the common code out from the SYS_NI macros into a new __SYS_NI macro.
Also conditionalize the X64 version in preparation for enabling syscall
wrappers on 32-bit native kernels.

Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
 arch/x86/include/asm/syscall_wrapper.h | 32 ++++++++++++++++++--------
 1 file changed, 23 insertions(+), 9 deletions(-)

diff --git a/arch/x86/include/asm/syscall_wrapper.h b/arch/x86/include/asm/syscall_wrapper.h
index 781adf7f611f..1166635cd841 100644
--- a/arch/x86/include/asm/syscall_wrapper.h
+++ b/arch/x86/include/asm/syscall_wrapper.h
@@ -42,6 +42,9 @@ struct pt_regs;
 		return sys_ni_syscall();				\
 	}
 
+#define __SYS_NI(abi, name)						\
+	SYSCALL_ALIAS(__##abi##_##name, sys_ni_posix_timers)
+
 #ifdef CONFIG_X86_64
 #define __X64_SYS_STUB0(sys_name)					\
 	__SYS_STUB0(x64, sys_name)
@@ -52,10 +55,14 @@ struct pt_regs;
 
 #define __X64_COND_SYSCALL(sys_name)					\
 	__COND_SYSCALL(x64, sys_name)
+
+#define __X64_SYS_NI(sys_name)						\
+	__SYS_NI(x64, sys_name)
 #else /* CONFIG_X86_64 */
 #define __X64_SYS_STUB0(sys_name)
 #define __X64_SYS_STUBx(x, sys_name, ...)
 #define __X64_COND_SYSCALL(sys_name)
+#define __X64_SYS_NI(sys_name)
 #endif /* CONFIG_X86_64 */
 
 #ifdef CONFIG_IA32_EMULATION
@@ -77,6 +84,9 @@ struct pt_regs;
 #define __IA32_COMPAT_COND_SYSCALL(compat_sys_name)			\
 	__COND_SYSCALL(ia32, compat_sys_name)
 
+#define __IA32_COMPAT_SYS_NI(compat_sys_name)				\
+	__SYS_NI(ia32, compat_sys_name)
+
 #define __IA32_SYS_STUB0(sys_name)					\
 	__SYS_STUB0(ia32, sys_name)
 
@@ -87,17 +97,17 @@ struct pt_regs;
 #define __IA32_COND_SYSCALL(sys_name)					\
 	__COND_SYSCALL(ia32, sys_name)
 
-#define SYS_NI(name)							\
-	SYSCALL_ALIAS(__x64_sys_##name, sys_ni_posix_timers);		\
-	SYSCALL_ALIAS(__ia32_sys_##name, sys_ni_posix_timers)
-
+#define __IA32_SYS_NI(sys_name)						\
+	__SYS_NI(ia32, sys_name)
 #else /* CONFIG_IA32_EMULATION */
 #define __IA32_COMPAT_SYS_STUB0(compat_sys_name)
 #define __IA32_COMPAT_SYS_STUBx(x, compat_sys_name, ...)
 #define __IA32_COMPAT_COND_SYSCALL(compat_sys_name)
+#define __IA32_COMPAT_SYS_NI(compat_sys_name)
 #define __IA32_SYS_STUB0(sys_name)
 #define __IA32_SYS_STUBx(x, sys_name, ...)
 #define __IA32_COND_SYSCALL(sys_name)
+#define __IA32_SYS_NI(sys_name)
 #endif /* CONFIG_IA32_EMULATION */
 
 
@@ -116,10 +126,14 @@ struct pt_regs;
 
 #define __X32_COMPAT_COND_SYSCALL(compat_sys_name)			\
 	__COND_SYSCALL(x32, compat_sys_name)
+
+#define __X32_COMPAT_SYS_NI(compat_sys_name)				\
+	__SYS_NI(x32, compat_sys_name)
 #else /* CONFIG_X86_X32 */
 #define __X32_COMPAT_SYS_STUB0(compat_sys_name)
 #define __X32_COMPAT_SYS_STUBx(x, compat_sys_name, ...)
 #define __X32_COMPAT_COND_SYSCALL(compat_sys_name)
+#define __X32_COMPAT_SYS_NI(compat_sys_name)
 #endif /* CONFIG_X86_X32 */
 
 
@@ -163,8 +177,8 @@ struct pt_regs;
 	__X32_COMPAT_COND_SYSCALL(compat_sys_##name)
 
 #define COMPAT_SYS_NI(name)						\
-	SYSCALL_ALIAS(__ia32_compat_sys_##name, sys_ni_posix_timers);	\
-	SYSCALL_ALIAS(__x32_compat_sys_##name, sys_ni_posix_timers)
+	__IA32_COMPAT_SYS_NI(compat_sys_##name)				\
+	__X32_COMPAT_SYS_NI(compat_sys_##name)
 
 #endif /* CONFIG_COMPAT */
 
@@ -236,9 +250,9 @@ struct pt_regs;
 	__X64_COND_SYSCALL(sys_##name)					\
 	__IA32_COND_SYSCALL(sys_##name)
 
-#ifndef SYS_NI
-#define SYS_NI(name) SYSCALL_ALIAS(__x64_sys_##name, sys_ni_posix_timers);
-#endif
+#define SYS_NI(name)							\
+	__X64_SYS_NI(sys_##name)					\
+	__IA32_SYS_NI(sys_##name)
 
 
 /*
-- 
2.24.1


  parent reply	other threads:[~2020-02-24 18:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 18:17 [PATCH v2 0/8] Enable pt_regs based syscalls for x86-32 native Brian Gerst
2020-02-24 18:17 ` [PATCH v2 1/8] x86, syscalls: Refactor SYSCALL_DEFINEx macros Brian Gerst
2020-02-25 19:42   ` Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 2/8] x86, syscalls: Refactor SYSCALL_DEFINE0 macros Brian Gerst
2020-02-25 19:47   ` Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 3/8] x86, syscalls: Refactor COND_SYSCALL macros Brian Gerst
2020-02-25 19:49   ` Dominik Brodowski
2020-02-24 18:17 ` Brian Gerst [this message]
2020-02-25 21:11   ` [PATCH v2 4/8] x86, syscalls: Refactor SYS_NI macros Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 5/8] x86: Move 32-bit compat syscalls to common location Brian Gerst
2020-02-25 21:18   ` Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 6/8] x86-32: Enable syscall wrappers Brian Gerst
2020-02-24 18:17 ` [PATCH v2 7/8] x86-64: Use syscall wrappers for x32_rt_sigreturn Brian Gerst
2020-02-24 18:17 ` [PATCH v2 8/8] x86: Drop asmlinkage from syscalls Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200224181757.724961-5-brgerst@gmail.com \
    --to=brgerst@gmail.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome