From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Brian Gerst <brgerst@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v2 1/8] x86, syscalls: Refactor SYSCALL_DEFINEx macros
Date: Tue, 25 Feb 2020 20:42:19 +0100 [thread overview]
Message-ID: <20200225194219.GA3954@light.dominikbrodowski.net> (raw)
In-Reply-To: <20200224181757.724961-2-brgerst@gmail.com>
Thanks for the updated series! Looks nicer to me now.
> +#ifdef CONFIG_X86_64
> +#define __X64_SYS_STUBx(x, sys_name, ...) \
> + __SYS_STUBx(x64, sys_name, \
> + SC_X86_64_REGS_TO_ARGS(x, __VA_ARGS__))
I'd say it's easier to read if "name" is passed to this macro, and it is
expanded to sys_##name only within this macro...
> +#define __IA32_COMPAT_SYS_STUBx(x, compat_sys_name, ...) \
> + __SYS_STUBx(ia32, compat_sys_name, \
> + SC_IA32_REGS_TO_ARGS(x, __VA_ARGS__))
... and in particular here (with compat_sys)
> +#define __IA32_SYS_STUBx(x, sys_name, ...) \
> + __SYS_STUBx(ia32, sys_name, \
> + SC_IA32_REGS_TO_ARGS(x, __VA_ARGS__))
... same here
> +#define __X32_COMPAT_SYS_STUBx(x, compat_sys_name, ...) \
> + __SYS_STUBx(x32, compat_sys_name, \
> + SC_X86_64_REGS_TO_ARGS(x, __VA_ARGS__))
... and here.
Otherwise, a nice cleanup!
Thanks,
Dominik
next prev parent reply other threads:[~2020-02-25 21:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 18:17 [PATCH v2 0/8] Enable pt_regs based syscalls for x86-32 native Brian Gerst
2020-02-24 18:17 ` [PATCH v2 1/8] x86, syscalls: Refactor SYSCALL_DEFINEx macros Brian Gerst
2020-02-25 19:42 ` Dominik Brodowski [this message]
2020-02-24 18:17 ` [PATCH v2 2/8] x86, syscalls: Refactor SYSCALL_DEFINE0 macros Brian Gerst
2020-02-25 19:47 ` Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 3/8] x86, syscalls: Refactor COND_SYSCALL macros Brian Gerst
2020-02-25 19:49 ` Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 4/8] x86, syscalls: Refactor SYS_NI macros Brian Gerst
2020-02-25 21:11 ` Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 5/8] x86: Move 32-bit compat syscalls to common location Brian Gerst
2020-02-25 21:18 ` Dominik Brodowski
2020-02-24 18:17 ` [PATCH v2 6/8] x86-32: Enable syscall wrappers Brian Gerst
2020-02-24 18:17 ` [PATCH v2 7/8] x86-64: Use syscall wrappers for x32_rt_sigreturn Brian Gerst
2020-02-24 18:17 ` [PATCH v2 8/8] x86: Drop asmlinkage from syscalls Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225194219.GA3954@light.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®