From: Mark Brown <broonie@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH] regulator: anatop: Drop error message for -EPROBE_DEFER
Date: Tue, 3 Mar 2020 12:30:10 +0000 [thread overview]
Message-ID: <20200303123010.GB3866@sirena.org.uk> (raw)
In-Reply-To: <1583205261-1994-1-git-send-email-Anson.Huang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Tue, Mar 03, 2020 at 11:14:21AM +0800, Anson Huang wrote:
> devm_regulator_register() could return -EPROBE_DEFER when trying to
> get init data and NOT all resources are available at that time, for
> this case, error message should NOT be present, the driver will call
> probe again later, so drop error message for -EPROBE_DEFER.
No, this is not good - it means that if there is some problem the user
will not get any information about why the driver is not instantiating
and how to fix it. At most lower the message to dev_dbg().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-03 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 3:14 Anson Huang
2020-03-03 12:30 ` Mark Brown [this message]
2020-03-03 13:23 ` Anson Huang
2020-03-03 13:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303123010.GB3866@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®