mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	hpa@zytor.com, linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86/unwind/orc: Do not skip the first frame unless explicitly asked for
Date: Wed, 4 Mar 2020 11:47:49 -0600	[thread overview]
Message-ID: <20200304174749.iwoyf5gp4lkb22t5@treble> (raw)
In-Reply-To: <20200304123259.32199-1-mbenes@suse.cz>

On Wed, Mar 04, 2020 at 01:32:59PM +0100, Miroslav Benes wrote:
> ORC unwinder can currently skip the first frame even if a user does not
> ask for it. If both regs and first_frame parameters of unwind_start()
> are set to NULL, state->sp and first_frame are later initialized to the
> same value for an inactive task. Given there is "less than or equal to"
> comparison used at the end of __unwind_start() for skipping stack frames,
> the first frame is always skipped in this case.
> 
> Drop the equal part of the comparison and make it equivalent to the
> frame pointer unwinder.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh


      reply	other threads:[~2020-03-04 17:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 12:32 Miroslav Benes
2020-03-04 17:47 ` Josh Poimboeuf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200304174749.iwoyf5gp4lkb22t5@treble \
    --to=jpoimboe@redhat.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®