mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86/unwind/orc: Do not skip the first frame unless explicitly asked for
@ 2020-03-04 12:32 Miroslav Benes
  2020-03-04 17:47 ` Josh Poimboeuf
  0 siblings, 1 reply; 2+ messages in thread
From: Miroslav Benes @ 2020-03-04 12:32 UTC (permalink / raw)
  To: jpoimboe, tglx, mingo, bp; +Cc: hpa, linux-kernel, x86, Miroslav Benes

ORC unwinder can currently skip the first frame even if a user does not
ask for it. If both regs and first_frame parameters of unwind_start()
are set to NULL, state->sp and first_frame are later initialized to the
same value for an inactive task. Given there is "less than or equal to"
comparison used at the end of __unwind_start() for skipping stack frames,
the first frame is always skipped in this case.

Drop the equal part of the comparison and make it equivalent to the
frame pointer unwinder.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
 arch/x86/kernel/unwind_orc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
index e9cc182aa97e..8452518cc20a 100644
--- a/arch/x86/kernel/unwind_orc.c
+++ b/arch/x86/kernel/unwind_orc.c
@@ -651,7 +651,7 @@ void __unwind_start(struct unwind_state *state, struct task_struct *task,
 	/* Otherwise, skip ahead to the user-specified starting frame: */
 	while (!unwind_done(state) &&
 	       (!on_stack(&state->stack_info, first_frame, sizeof(long)) ||
-			state->sp <= (unsigned long)first_frame))
+			state->sp < (unsigned long)first_frame))
 		unwind_next_frame(state);
 
 	return;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-04 17:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 12:32 [PATCH] x86/unwind/orc: Do not skip the first frame unless explicitly asked for Miroslav Benes
2020-03-04 17:47 ` Josh Poimboeuf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®