[driver-core:driver-core-testing 6/17] drivers/base/core.c:2335:5: sparse: sparse: symbol 'fw_devlink_flags' was not declared. Should it be static?

[driver-core:driver-core-testing 6/17] drivers/base/core.c:2335:5: sparse: sparse: symbol 'fw_devlink_flags' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
head:   68464d79015a1bbb41872a9119a07b2cb151a4b9
commit: 8375e74f2bca9802a4ddf431a6d7bd2ab9950f27 [6/17] driver core: Add fw_devlink kernel commandline option
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-174-g094d5a94-dirty
        git checkout 8375e74f2bca9802a4ddf431a6d7bd2ab9950f27
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/base/core.c:2335:5: sparse: sparse: symbol 'fw_devlink_flags' was not declared. Should it be static?
   drivers/base/core.c:67:5: sparse: sparse: context imbalance in 'device_links_read_lock' - wrong count at exit
   include/linux/srcu.h:181:9: sparse: sparse: context imbalance in 'device_links_read_unlock' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[RFC PATCH driver-core] driver core: fw_devlink_flags can be static

[kbuild test robot]

Fixes: 8375e74f2bca ("driver core: Add fw_devlink kernel commandline option")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 26acb92aa966c..cd78a001d7198 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2332,7 +2332,7 @@ static int device_private_init(struct device *dev)
 	return 0;
 }
 
-u32 fw_devlink_flags;
+static u32 fw_devlink_flags;
 static int __init fw_devlink_setup(char *arg)
 {
 	if (!arg)