[PATCH] platform/x86: GPD pocket fan: Fix error message when temp-limits are out of range

[PATCH] platform/x86: GPD pocket fan: Fix error message when temp-limits are out of range

[Hans de Goede]

Commit 1f27dbd8265d ("platform/x86: GPD pocket fan: Allow somewhat
lower/higher temperature limits") changed the module-param sanity check
to accept temperature limits between 20 and 90 degrees celcius.

But the error message printed when the module params are outside this
range was not updated. This commit updates the error message to match
the new min and max value for the temp-limits.

Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/gpd-pocket-fan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/gpd-pocket-fan.c b/drivers/platform/x86/gpd-pocket-fan.c
index b471b86c28fe..5b516e4c2bfb 100644
--- a/drivers/platform/x86/gpd-pocket-fan.c
+++ b/drivers/platform/x86/gpd-pocket-fan.c
@@ -128,7 +128,7 @@ static int gpd_pocket_fan_probe(struct platform_device *pdev)
 
 	for (i = 0; i < ARRAY_SIZE(temp_limits); i++) {
 		if (temp_limits[i] < 20000 || temp_limits[i] > 90000) {
-			dev_err(&pdev->dev, "Invalid temp-limit %d (must be between 40000 and 70000)\n",
+			dev_err(&pdev->dev, "Invalid temp-limit %d (must be between 20000 and 90000)\n",
 				temp_limits[i]);
 			temp_limits[0] = TEMP_LIMIT0_DEFAULT;
 			temp_limits[1] = TEMP_LIMIT1_DEFAULT;
-- 
2.25.1

Re: [PATCH] platform/x86: GPD pocket fan: Fix error message when temp-limits are out of range

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

On Fri 2020-03-06 10:17:24, Hans de Goede wrote:
> Commit 1f27dbd8265d ("platform/x86: GPD pocket fan: Allow somewhat
> lower/higher temperature limits") changed the module-param sanity check
> to accept temperature limits between 20 and 90 degrees celcius.
> 
> But the error message printed when the module params are outside this
> range was not updated. This commit updates the error message to match
> the new min and max value for the temp-limits.
> 
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Pavel Machek <pavel@denx.de>

Thanks!
							Pavel
							
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]