From: Pratyush Yadav <p.yadav@ti.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mark Brown <broonie@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Pratyush Yadav <p.yadav@ti.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Sekhar Nori <nsekhar@ti.com>
Subject: [PATCH v3 05/12] mtd: spi-nor: default to address width of 3 for configurable widths
Date: Fri, 13 Mar 2020 21:16:38 +0530 [thread overview]
Message-ID: <20200313154645.29293-6-p.yadav@ti.com> (raw)
In-Reply-To: <20200313154645.29293-1-p.yadav@ti.com>
JESD216D.01 says that when the address width can be 3 or 4, it defaults
to 3 and enters 4-byte mode when given the appropriate command. So, when
we see a configurable width, default to 3 and let flash that default to
4 change it in a post-bfpt fixup.
This fixes SMPT parsing for flashes with configurable address width. If
the SMPT descriptor advertises variable address width, we use
nor->addr_width as the address width. But since it was not set to any
value from the SFDP table, the read command uses an address width of 0,
resulting in an incorrect read being issued.
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
---
drivers/mtd/spi-nor/spi-nor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 9e0724f2a825..9335692e9bcb 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -3772,6 +3772,7 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,
/* Number of address bytes. */
switch (bfpt.dwords[BFPT_DWORD(1)] & BFPT_DWORD1_ADDRESS_BYTES_MASK) {
case BFPT_DWORD1_ADDRESS_BYTES_3_ONLY:
+ case BFPT_DWORD1_ADDRESS_BYTES_3_OR_4:
nor->addr_width = 3;
break;
--
2.25.0
next prev parent reply other threads:[~2020-03-13 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:46 [PATCH v3 00/12] mtd: spi-nor: add xSPI Octal DTR support Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 01/12] spi: spi-mem: allow specifying whether an op is DTR or not Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 02/12] spi: atmel-quadspi: reject DTR ops Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 03/12] spi: spi-mem: allow specifying a command's extension Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 04/12] mtd: spi-nor: add support for DTR protocol Pratyush Yadav
2020-03-13 15:46 ` Pratyush Yadav [this message]
2020-03-13 15:46 ` [PATCH v3 06/12] mtd: spi-nor: get command opcode extension type from BFPT Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 07/12] mtd: spi-nor: parse xSPI Profile 1.0 table Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 08/12] mtd: spi-nor: use dummy cycle and address width info from SFDP Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 09/12] mtd: spi-nor: enable octal DTR mode when possible Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 10/12] mtd: spi-nor: perform a Soft Reset on shutdown Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 11/12] mtd: spi-nor: Disable Octal DTR mode on suspend Pratyush Yadav
2020-03-13 15:46 ` [PATCH v3 12/12] mtd: spi-nor: add support for Cypress Semper flash Pratyush Yadav
2020-03-13 15:50 ` [PATCH v3 00/12] mtd: spi-nor: add xSPI Octal DTR support Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313154645.29293-6-p.yadav@ti.com \
--to=p.yadav@ti.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsekhar@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®