From: David Miller <davem@davemloft.net>
To: grygorii.strashko@ti.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, dmurphy@ti.com,
hkallweit1@gmail.com, netdev@vger.kernel.org, nsekhar@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: dp83867: w/a for fld detect threshold bootstrapping issue
Date: Sat, 21 Mar 2020 20:10:22 -0700 (PDT) [thread overview]
Message-ID: <20200321.201022.719210614219273669.davem@davemloft.net> (raw)
In-Reply-To: <20200317180454.22393-1-grygorii.strashko@ti.com>
From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Tue, 17 Mar 2020 20:04:54 +0200
> When the DP83867 PHY is strapped to enable Fast Link Drop (FLD) feature
> STRAP_STS2.STRAP_ FLD (reg 0x006F bit 10), the Energy Lost Threshold for
> FLD Energy Lost Mode FLD_THR_CFG.ENERGY_LOST_FLD_THR (reg 0x002e bits 2:0)
> will be defaulted to 0x2. This may cause the phy link to be unstable. The
> new DP83867 DM recommends to always restore ENERGY_LOST_FLD_THR to 0x1.
>
> Hence, restore default value of FLD_THR_CFG.ENERGY_LOST_FLD_THR to 0x1 when
> FLD is enabled by bootstrapping as recommended by DM.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Applied, thank you.
Let me know if I should queue this up for -stable.
next prev parent reply other threads:[~2020-03-22 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 18:04 Grygorii Strashko
2020-03-22 3:10 ` David Miller [this message]
2020-03-23 20:36 ` Grygorii Strashko
2020-03-24 1:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321.201022.719210614219273669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®