* [RFC PATCH v1 31/50] lib/nodemask.c: Use cheaper prandom_u32_max() in node_random()
@ 2019-11-29 21:44 George Spelvin
0 siblings, 0 replies; only message in thread
From: George Spelvin @ 2019-11-29 21:44 UTC (permalink / raw)
To: linux-kernel, lkml; +Cc: Michal Hocko, Mel Gorman
This function is to spread things around uniformly; cryptographic
unguessability is not required.
Signed-off-by: George Spelvin <lkml@sdf.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mel Gorman <mgorman@suse.de>
---
lib/nodemask.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/nodemask.c b/lib/nodemask.c
index 3aa454c54c0de..330f9c7d3da97 100644
--- a/lib/nodemask.c
+++ b/lib/nodemask.c
@@ -25,7 +25,7 @@ int node_random(const nodemask_t *maskp)
w = nodes_weight(*maskp);
if (w)
bit = bitmap_ord_to_pos(maskp->bits,
- get_random_int() % w, MAX_NUMNODES);
+ prandom_u32_max(w), MAX_NUMNODES);
return bit;
}
#endif
--
2.26.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-28 16:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 21:44 [RFC PATCH v1 31/50] lib/nodemask.c: Use cheaper prandom_u32_max() in node_random() George Spelvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®