* [PATCH] kernfs: Change kernfs_node lockdep name to "kn->active"
@ 2020-04-02 17:10 Waiman Long
2020-04-03 14:32 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Waiman Long @ 2020-04-02 17:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Tejun Heo; +Cc: linux-kernel, Waiman Long
The kernfs_node lockdep tracking is being done on kn->active, the
active reference count. The other reference count (kn->count) is not
tracked by lockdep. So change the lockdep name to reflect what it is
tracking.
Signed-off-by: Waiman Long <longman@redhat.com>
---
fs/kernfs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index 34366db3620d..fd6ddfe4cd94 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -1010,7 +1010,7 @@ struct kernfs_node *__kernfs_create_file(struct kernfs_node *parent,
#ifdef CONFIG_DEBUG_LOCK_ALLOC
if (key) {
- lockdep_init_map(&kn->dep_map, "kn->count", key, 0);
+ lockdep_init_map(&kn->dep_map, "kn->active", key, 0);
kn->flags |= KERNFS_LOCKDEP;
}
#endif
--
2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kernfs: Change kernfs_node lockdep name to "kn->active"
2020-04-02 17:10 [PATCH] kernfs: Change kernfs_node lockdep name to "kn->active" Waiman Long
@ 2020-04-03 14:32 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2020-04-03 14:32 UTC (permalink / raw)
To: Waiman Long; +Cc: Greg Kroah-Hartman, linux-kernel
On Thu, Apr 02, 2020 at 01:10:56PM -0400, Waiman Long wrote:
> The kernfs_node lockdep tracking is being done on kn->active, the
> active reference count. The other reference count (kn->count) is not
> tracked by lockdep. So change the lockdep name to reflect what it is
> tracking.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-03 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 17:10 [PATCH] kernfs: Change kernfs_node lockdep name to "kn->active" Waiman Long
2020-04-03 14:32 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®