[PATCH] tracing: Remove blank line before right brace '}'

[PATCH] tracing: Remove blank line before right brace '}'

[ahio.lee0]

From: Ahio Lee <ahio.lee0@gmail.com>

No need to insert a weird blank line before right brace '}'.

Signed-off-by: Ahio Lee <ahio.lee0@gmail.com>
---
 kernel/trace/ring_buffer.c   | 1 -
 kernel/trace/trace.c         | 2 --
 kernel/trace/trace_irqsoff.c | 1 -
 3 files changed, 4 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 61f0e92ace99..9db44db5642a 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -3095,7 +3095,6 @@ void ring_buffer_discard_commit(struct trace_buffer *buffer,
 	trace_recursive_unlock(cpu_buffer);
 
 	preempt_enable_notrace();
-
 }
 EXPORT_SYMBOL_GPL(ring_buffer_discard_commit);
 
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 6b11e4e2150c..b780934547d3 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2973,7 +2973,6 @@ static void __ftrace_trace_stack(struct trace_buffer *buffer,
 	barrier();
 	__this_cpu_dec(ftrace_stack_reserve);
 	preempt_enable_notrace();
-
 }
 
 static inline void ftrace_trace_stack(struct trace_array *tr,
@@ -8195,7 +8194,6 @@ create_trace_option_file(struct trace_array *tr,
 
 	topt->entry = trace_create_file(opt->name, 0644, t_options, topt,
 				    &trace_options_fops);
-
 }
 
 static void
diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
index 10bbb0f381d5..042452ecd18e 100644
--- a/kernel/trace/trace_irqsoff.c
+++ b/kernel/trace/trace_irqsoff.c
@@ -228,7 +228,6 @@ static void irqsoff_trace_open(struct trace_iterator *iter)
 {
 	if (is_graph(iter->tr))
 		graph_trace_open(iter);
-
 }
 
 static void irqsoff_trace_close(struct trace_iterator *iter)
-- 
2.11.0

Re: [PATCH] tracing: Remove blank line before right brace '}'

[Steven Rostedt]

On Sun,  5 Apr 2020 22:27:29 +0800
ahio.lee0@gmail.com wrote:

> From: Ahio Lee <ahio.lee0@gmail.com>
> 
> No need to insert a weird blank line before right brace '}'.
> 
> Signed-off-by: Ahio Lee <ahio.lee0@gmail.com>

I'm sorry but I'm not concerned about "weird blank line"s. This just adds
unnecessary churn, and doesn't make the code any more readable.

-- Steve