* [PATCH] fs: only pass valid chmod mode_t bits to security_path_chmod
@ 2020-04-13 8:56 daurnimator
0 siblings, 0 replies; only message in thread
From: daurnimator @ 2020-04-13 8:56 UTC (permalink / raw)
Cc: quae, Alexander Viro, linux-fsdevel, linux-kernel
chmod only pays attention to some of the flags in umode_t, don't pass
on irrelevant flags to security_path_chmod.
Signed-off-by: daurnimator <quae@daurnimator.com>
---
fs/open.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/open.c b/fs/open.c
index b69d6eed67e6..a2d8bee88a3c 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -551,12 +551,13 @@ static int chmod_common(const struct path *path, umode_t mode)
error = mnt_want_write(path->mnt);
if (error)
return error;
+ mode &= S_IALLUGO;
retry_deleg:
inode_lock(inode);
error = security_path_chmod(path, mode);
if (error)
goto out_unlock;
- newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
+ newattrs.ia_mode = mode | (inode->i_mode & ~S_IALLUGO);
newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
error = notify_change(path->dentry, &newattrs, &delegated_inode);
out_unlock:
--
2.26.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-13 9:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 8:56 [PATCH] fs: only pass valid chmod mode_t bits to security_path_chmod daurnimator
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®