From: Borislav Petkov <bp@suse.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leonro@mellanox.com>,
Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use
Date: Tue, 14 Apr 2020 18:03:50 +0200 [thread overview]
Message-ID: <20200414160349.GH31763@zn.tnic> (raw)
In-Reply-To: <20200414155732.1236944-5-leon@kernel.org>
On Tue, Apr 14, 2020 at 06:57:32PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> VERMAGIC* definitions are not supposed to be used by the drivers,
Yeah, this was only me conjecturing here. But yes, if people agree, this
would be one way to do it.
In any case and FWIW, series looks ok to me:
Acked-by: Borislav Petkov <bp@suse.de>
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2020-04-14 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:57 [PATCH net-next 0/4] Remove vermagic header from global include folder Leon Romanovsky
2020-04-14 15:57 ` [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use Leon Romanovsky
2020-04-14 16:03 ` Borislav Petkov [this message]
2020-04-14 18:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414160349.GH31763@zn.tnic \
--to=bp@suse.de \
--cc=davem@davemloft.net \
--cc=jeyu@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®