mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	linux-kernel@vger.kernel.org,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Jonathan Corbet <corbet@lwn.net>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v3 1/3] lib/vsprintf: Print time64_t in human readable format
Date: Thu, 16 Apr 2020 11:32:19 +0900	[thread overview]
Message-ID: <20200416023219.GA30641@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200415170046.33374-2-andriy.shevchenko@linux.intel.com>

On (20/04/15 20:00), Andy Shevchenko wrote:
[..]
>  #include <linux/of.h>
>  #include <net/addrconf.h>
> @@ -1819,6 +1820,29 @@ char *rtc_str(char *buf, char *end, const struct rtc_time *tm,
>  	return buf;
>  }
>  
> +static noinline_for_stack
> +char *time64_str(char *buf, char *end, const time64_t time,
> +		 struct printf_spec spec, const char *fmt)
> +{
> +	struct rtc_time rtc_time;
> +	struct tm tm;
> +
> +	time64_to_tm(time, 0, &tm);
> +
> +	rtc_time.tm_sec = tm.tm_sec;
> +	rtc_time.tm_min = tm.tm_min;
> +	rtc_time.tm_hour = tm.tm_hour;
> +	rtc_time.tm_mday = tm.tm_mday;
> +	rtc_time.tm_mon = tm.tm_mon;
> +	rtc_time.tm_year = tm.tm_year;
> +	rtc_time.tm_wday = tm.tm_wday;
> +	rtc_time.tm_yday = tm.tm_yday;
> +
> +	rtc_time.tm_isdst = 0;

Here you convert time64_t (signed, we also have unsigned version - timeu64_t)
to tm first and then convert tm to rtc_time. Will rtc_time64_to_tm() do the
trick?

	-ss

  reply	other threads:[~2020-04-16  2:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 17:00 [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 1/3] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2020-04-16  2:32   ` Sergey Senozhatsky [this message]
2020-04-21 13:08     ` Andy Shevchenko
2020-04-23  1:54       ` Sergey Senozhatsky
2020-04-23 10:43         ` Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 2/3] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2020-04-16  2:53   ` Sergey Senozhatsky
2020-04-16  3:02     ` Sergey Senozhatsky
2020-04-21 13:09     ` Andy Shevchenko
2020-06-16 15:53   ` Nicolas Saenz Julienne
2020-06-16 16:13     ` Andy Shevchenko
2020-06-16 16:22       ` Nicolas Saenz Julienne
2020-06-16 16:32         ` Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 3/3] [media] usb: pulse8-cec: " Andy Shevchenko
2020-04-15 17:20 ` [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t Steven Rostedt
2020-04-16  2:34   ` Sergey Senozhatsky
2020-04-16  2:46     ` Joe Perches
2020-04-21 13:07       ` Andy Shevchenko
2020-05-15 16:02 ` Petr Mladek
2020-05-20 11:43   ` Sergey Senozhatsky
2020-05-21  8:45     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416023219.GA30641@jagdpanzerIV.localdomain \
    --to=sergey.senozhatsky@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®