From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 2/3] ARM: bcm2835: Switch to use %ptT
Date: Thu, 16 Apr 2020 11:53:58 +0900 [thread overview]
Message-ID: <20200416025358.GC30641@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200415170046.33374-3-andriy.shevchenko@linux.intel.com>
On (20/04/15 20:00), Andy Shevchenko wrote:
[..]
> diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
> index da26a584dca0..a3e85186f8e6 100644
> --- a/drivers/firmware/raspberrypi.c
> +++ b/drivers/firmware/raspberrypi.c
> @@ -182,16 +182,10 @@ rpi_firmware_print_firmware_revision(struct rpi_firmware *fw)
> RPI_FIRMWARE_GET_FIRMWARE_REVISION,
> &packet, sizeof(packet));
>
> - if (ret == 0) {
> - struct tm tm;
> -
> - time64_to_tm(packet, 0, &tm);
> + if (ret)
> + return;
>
> - dev_info(fw->cl.dev,
> - "Attached to firmware from %04ld-%02d-%02d %02d:%02d\n",
> - tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday,
> - tm.tm_hour, tm.tm_min);
> - }
> + dev_info(fw->cl.dev, "Attached to firmware from %ptT\n", &packet);
> }
So can this be instead:
struct rtc_time tm;
rtc_time64_to_tm(time, &tm);
dev_info(.... "%ptR", &tm);
?
If it can, then I'd probably say something like "can we then just use
rtc_time64_to_tm()"?
-ss
next prev parent reply other threads:[~2020-04-16 2:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 17:00 [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 1/3] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2020-04-16 2:32 ` Sergey Senozhatsky
2020-04-21 13:08 ` Andy Shevchenko
2020-04-23 1:54 ` Sergey Senozhatsky
2020-04-23 10:43 ` Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 2/3] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2020-04-16 2:53 ` Sergey Senozhatsky [this message]
2020-04-16 3:02 ` Sergey Senozhatsky
2020-04-21 13:09 ` Andy Shevchenko
2020-06-16 15:53 ` Nicolas Saenz Julienne
2020-06-16 16:13 ` Andy Shevchenko
2020-06-16 16:22 ` Nicolas Saenz Julienne
2020-06-16 16:32 ` Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 3/3] [media] usb: pulse8-cec: " Andy Shevchenko
2020-04-15 17:20 ` [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t Steven Rostedt
2020-04-16 2:34 ` Sergey Senozhatsky
2020-04-16 2:46 ` Joe Perches
2020-04-21 13:07 ` Andy Shevchenko
2020-05-15 16:02 ` Petr Mladek
2020-05-20 11:43 ` Sergey Senozhatsky
2020-05-21 8:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416025358.GC30641@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®