From: Mark Brown <broonie@kernel.org>
To: Clement Leger <cleger@kalray.eu>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data
Date: Thu, 16 Apr 2020 12:35:39 +0100 [thread overview]
Message-ID: <20200416113539.GG5354@sirena.org.uk> (raw)
In-Reply-To: <20200416110916.22633-2-cleger@kalray.eu>
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On Thu, Apr 16, 2020 at 01:09:16PM +0200, Clement Leger wrote:
> Since these members were initialized only with previous dw_spi_chip
> struct members and that there is no user anymore, remove them. Along
> this removal, remove code path which were using these members.
This means that your first patch will break the build, to keep things
bisectable please do some combination of moving this before the first
patch and squashing it into the first patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-16 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 11:08 [PATCH 0/2] Cleanup chip info in spi-dw driver Clement Leger
2020-04-16 11:09 ` [PATCH 1/2] spi: dw: remove unused dw_spi_chip handling Clement Leger
2020-04-16 11:09 ` [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data Clement Leger
2020-04-16 11:35 ` Mark Brown [this message]
2020-04-16 11:50 ` Clément Leger
2020-04-16 12:47 ` Mark Brown
2020-04-16 12:58 ` Clément Leger
2020-04-16 15:45 ` [PATCH 0/2] Cleanup chip info in spi-dw driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416113539.GG5354@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cleger@kalray.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®