From: "Clément Leger" <cleger@kalrayinc.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data
Date: Thu, 16 Apr 2020 13:50:55 +0200 (CEST) [thread overview]
Message-ID: <622416308.15749883.1587037855167.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <20200416113539.GG5354@sirena.org.uk>
Hi Mark,
Sorry, maybe the commit message was not clear enough but actually
these fields were not initialized so it does not break anything
(ie, the default values were always used).
Clément
----- On 16 Apr, 2020, at 13:35, Mark Brown broonie@kernel.org wrote:
> On Thu, Apr 16, 2020 at 01:09:16PM +0200, Clement Leger wrote:
>> Since these members were initialized only with previous dw_spi_chip
>> struct members and that there is no user anymore, remove them. Along
>> this removal, remove code path which were using these members.
>
> This means that your first patch will break the build, to keep things
> bisectable please do some combination of moving this before the first
> patch and squashing it into the first patch.
next prev parent reply other threads:[~2020-04-16 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 11:08 [PATCH 0/2] Cleanup chip info in spi-dw driver Clement Leger
2020-04-16 11:09 ` [PATCH 1/2] spi: dw: remove unused dw_spi_chip handling Clement Leger
2020-04-16 11:09 ` [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data Clement Leger
2020-04-16 11:35 ` Mark Brown
2020-04-16 11:50 ` Clément Leger [this message]
2020-04-16 12:47 ` Mark Brown
2020-04-16 12:58 ` Clément Leger
2020-04-16 15:45 ` [PATCH 0/2] Cleanup chip info in spi-dw driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=622416308.15749883.1587037855167.JavaMail.zimbra@kalray.eu \
--to=cleger@kalrayinc.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome