From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <hdanton@sina.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] sched: make p->prio independent of p->mm
Date: Thu, 23 Apr 2020 20:41:22 -0400 [thread overview]
Message-ID: <20200423204122.4c19b835@gandalf.local.home> (raw)
In-Reply-To: <20200424003028.14800-1-hdanton@sina.com>
On Fri, 24 Apr 2020 08:30:28 +0800
Hillf Danton <hdanton@sina.com> wrote:
> > I believe Peter meant axing the double check, not the check together.
> >
> > That is, instead of:
> >
> > if (p->flags & PF_KTHREAD) {
> > if (attr->sched_priority > MAX_RT_PRIO - 1)
> > return -EINVAL;
> > } else {
> > if (attr->sched_priority > MAX_USER_RT_PRIO - 1)
> > return -EINVAL;
> > }
> >
> > Just have:
> >
> > if (attr->sched_priority > MAX_RT_PRIO -1)
> > return -EINVAL;
> >
> Got it, thank you :) Spin in couple of days.
I still think getting rid of MAX_USER_RT_PRIO would be good too.
-- Steve
next prev parent reply other threads:[~2020-04-24 0:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200423040128.6120-1-hdanton@sina.com>
2020-04-23 9:26 ` Peter Zijlstra
2020-04-23 13:44 ` Steven Rostedt
[not found] ` <20200423141609.5224-1-hdanton@sina.com>
2020-04-23 15:01 ` Steven Rostedt
[not found] ` <20200424003028.14800-1-hdanton@sina.com>
2020-04-24 0:41 ` Steven Rostedt [this message]
[not found] ` <20200424021231.13676-1-hdanton@sina.com>
2020-04-24 12:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423204122.4c19b835@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=efault@gmx.de \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome