* [PATCH RESEND] perf tools: Fix function name in comment
@ 2020-04-29 6:33 Shaokun Zhang
2020-04-29 14:34 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr() tip-bot2 for Shaokun Zhang
0 siblings, 2 replies; 3+ messages in thread
From: Shaokun Zhang @ 2020-04-29 6:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Shaokun Zhang, Arnaldo Carvalho de Melo, Andi Kleen
get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c,
fix the name in comment.
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
tools/perf/pmu-events/pmu-events.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
index 53e76d5d5b37..c8f306b572f4 100644
--- a/tools/perf/pmu-events/pmu-events.h
+++ b/tools/perf/pmu-events/pmu-events.h
@@ -26,7 +26,7 @@ struct pmu_event {
* Map a CPU to its table of PMU events. The CPU is identified by the
* cpuid field, which is an arch-specific identifier for the CPU.
* The identifier specified in tools/perf/pmu-events/arch/xxx/mapfile
- * must match the get_cpustr() in tools/perf/arch/xxx/util/header.c)
+ * must match the get_cpuid_str() in tools/perf/arch/xxx/util/header.c)
*
* The cpuid can contain any character other than the comma.
*/
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] perf tools: Fix function name in comment
2020-04-29 6:33 [PATCH RESEND] perf tools: Fix function name in comment Shaokun Zhang
@ 2020-04-29 14:34 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr() tip-bot2 for Shaokun Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-04-29 14:34 UTC (permalink / raw)
To: Shaokun Zhang; +Cc: linux-kernel, Andi Kleen
Em Wed, Apr 29, 2020 at 02:33:12PM +0800, Shaokun Zhang escreveu:
> get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c,
> fix the name in comment.
>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> CC: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> tools/perf/pmu-events/pmu-events.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
> index 53e76d5d5b37..c8f306b572f4 100644
> --- a/tools/perf/pmu-events/pmu-events.h
> +++ b/tools/perf/pmu-events/pmu-events.h
> @@ -26,7 +26,7 @@ struct pmu_event {
> * Map a CPU to its table of PMU events. The CPU is identified by the
> * cpuid field, which is an arch-specific identifier for the CPU.
> * The identifier specified in tools/perf/pmu-events/arch/xxx/mapfile
> - * must match the get_cpustr() in tools/perf/arch/xxx/util/header.c)
> + * must match the get_cpuid_str() in tools/perf/arch/xxx/util/header.c)
> *
> * The cpuid can contain any character other than the comma.
> */
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: perf/core] perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr()
2020-04-29 6:33 [PATCH RESEND] perf tools: Fix function name in comment Shaokun Zhang
2020-04-29 14:34 ` Arnaldo Carvalho de Melo
@ 2020-05-08 13:05 ` tip-bot2 for Shaokun Zhang
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Shaokun Zhang @ 2020-05-08 13:05 UTC (permalink / raw)
To: linux-tip-commits
Cc: Shaokun Zhang, Andi Kleen, Arnaldo Carvalho de Melo, x86, LKML
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 454a8be0cff954f18729964317b40ef2c3031364
Gitweb: https://git.kernel.org/tip/454a8be0cff954f18729964317b40ef2c3031364
Author: Shaokun Zhang <zhangshaokun@hisilicon.com>
AuthorDate: Wed, 29 Apr 2020 14:33:12 +08:00
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Thu, 30 Apr 2020 10:48:33 -03:00
perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr()
get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c,
fix the name in comment.
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Andi Kleen <ak@linux.intel.com>
Link: http://lore.kernel.org/lkml/1588141992-48382-1-git-send-email-zhangshaokun@hisilicon.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/pmu-events/pmu-events.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
index 53e76d5..c8f306b 100644
--- a/tools/perf/pmu-events/pmu-events.h
+++ b/tools/perf/pmu-events/pmu-events.h
@@ -26,7 +26,7 @@ struct pmu_event {
* Map a CPU to its table of PMU events. The CPU is identified by the
* cpuid field, which is an arch-specific identifier for the CPU.
* The identifier specified in tools/perf/pmu-events/arch/xxx/mapfile
- * must match the get_cpustr() in tools/perf/arch/xxx/util/header.c)
+ * must match the get_cpuid_str() in tools/perf/arch/xxx/util/header.c)
*
* The cpuid can contain any character other than the comma.
*/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-08 13:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 6:33 [PATCH RESEND] perf tools: Fix function name in comment Shaokun Zhang
2020-04-29 14:34 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr() tip-bot2 for Shaokun Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®