* [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()
@ 2020-04-26 9:40 Jason Yan
2020-04-27 7:47 ` Chi-Hsien Lin
2020-05-04 9:50 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-26 9:40 UTC (permalink / raw)
To: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, kvalo, davem, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, netdev, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40:
WARNING: Comparison to bool
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
index 8cc52935fd41..2b7837887c0b 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
@@ -2356,7 +2356,7 @@ struct brcmf_fws_info *brcmf_fws_attach(struct brcmf_pub *drvr)
fws->drvr = drvr;
fws->fcmode = drvr->settings->fcmode;
- if ((drvr->bus_if->always_use_fws_queue == false) &&
+ if (!drvr->bus_if->always_use_fws_queue &&
(fws->fcmode == BRCMF_FWS_FCMODE_NONE)) {
fws->avoid_queueing = true;
brcmf_dbg(INFO, "FWS queueing will be avoided\n");
--
2.21.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()
2020-04-26 9:40 [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach() Jason Yan
@ 2020-04-27 7:47 ` Chi-Hsien Lin
2020-05-04 9:50 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Chi-Hsien Lin @ 2020-04-27 7:47 UTC (permalink / raw)
To: Jason Yan, arend.vanspriel, franky.lin, hante.meuleman,
wright.feng, kvalo, davem, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, netdev, linux-kernel
On 04/26/2020 5:40, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40:
> WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> index 8cc52935fd41..2b7837887c0b 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> @@ -2356,7 +2356,7 @@ struct brcmf_fws_info *brcmf_fws_attach(struct brcmf_pub *drvr)
> fws->drvr = drvr;
> fws->fcmode = drvr->settings->fcmode;
>
> - if ((drvr->bus_if->always_use_fws_queue == false) &&
> + if (!drvr->bus_if->always_use_fws_queue &&
> (fws->fcmode == BRCMF_FWS_FCMODE_NONE)) {
> fws->avoid_queueing = true;
> brcmf_dbg(INFO, "FWS queueing will be avoided\n");
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()
2020-04-26 9:40 [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach() Jason Yan
2020-04-27 7:47 ` Chi-Hsien Lin
@ 2020-05-04 9:50 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-05-04 9:50 UTC (permalink / raw)
To: Jason Yan
Cc: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, davem, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, linux-kernel, Jason Yan
Jason Yan <yanaijie@huawei.com> wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40:
> WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> Reviewed-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
Patch applied to wireless-drivers-next.git, thanks.
ff2af09f4515 brcmfmac: remove comparison to bool in brcmf_fws_attach()
--
https://patchwork.kernel.org/patch/11510329/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-04 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 9:40 [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach() Jason Yan
2020-04-27 7:47 ` Chi-Hsien Lin
2020-05-04 9:50 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®