* [PATCH net v1] net: enetc: fix an issue about leak system resources
@ 2020-05-04 12:01 Dejin Zheng
2020-05-04 14:03 ` Vladimir Oltean
2020-05-04 17:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dejin Zheng @ 2020-05-04 12:01 UTC (permalink / raw)
To: claudiu.manoil, davem, vladimir.oltean, netdev
Cc: linux-kernel, Dejin Zheng, Andy Shevchenko
the related system resources were not released when enetc_hw_alloc()
return error in the enetc_pci_mdio_probe(), add iounmap() for error
handling label "err_hw_alloc" to fix it.
Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
index ebc635f8a4cc..15f37c5b8dc1 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
@@ -74,8 +74,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
pci_disable_device(pdev);
err_pci_enable:
err_mdiobus_alloc:
- iounmap(port_regs);
err_hw_alloc:
+ iounmap(port_regs);
err_ioremap:
return err;
}
--
2.25.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] net: enetc: fix an issue about leak system resources
2020-05-04 12:01 [PATCH net v1] net: enetc: fix an issue about leak system resources Dejin Zheng
@ 2020-05-04 14:03 ` Vladimir Oltean
2020-05-04 17:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2020-05-04 14:03 UTC (permalink / raw)
To: Dejin Zheng
Cc: Claudiu Manoil, David S. Miller, Vladimir Oltean, netdev, lkml,
Andy Shevchenko
On Mon, 4 May 2020 at 15:04, Dejin Zheng <zhengdejin5@gmail.com> wrote:
>
> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.
>
> Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> index ebc635f8a4cc..15f37c5b8dc1 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> @@ -74,8 +74,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
> pci_disable_device(pdev);
> err_pci_enable:
> err_mdiobus_alloc:
> - iounmap(port_regs);
> err_hw_alloc:
> + iounmap(port_regs);
> err_ioremap:
> return err;
> }
> --
> 2.25.0
>
Thanks!
-Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] net: enetc: fix an issue about leak system resources
2020-05-04 12:01 [PATCH net v1] net: enetc: fix an issue about leak system resources Dejin Zheng
2020-05-04 14:03 ` Vladimir Oltean
@ 2020-05-04 17:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-04 17:52 UTC (permalink / raw)
To: zhengdejin5
Cc: claudiu.manoil, vladimir.oltean, netdev, linux-kernel, andy.shevchenko
From: Dejin Zheng <zhengdejin5@gmail.com>
Date: Mon, 4 May 2020 20:01:27 +0800
> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.
>
> Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-04 17:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 12:01 [PATCH net v1] net: enetc: fix an issue about leak system resources Dejin Zheng
2020-05-04 14:03 ` Vladimir Oltean
2020-05-04 17:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®