* [PATCH -next] ipack: tpci200: fix error return code in tpci200_register()
@ 2020-05-07 9:42 Wei Yongjun
2020-05-07 14:34 ` Samuel Iglesias Gonsálvez
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2020-05-07 9:42 UTC (permalink / raw)
To: Samuel Iglesias Gonsalvez, Jens Taprogge, Greg Kroah-Hartman,
Zhouyang Jia, Kees Cook
Cc: Wei Yongjun, industrypack-devel, linux-kernel, kernel-janitors,
Hulk Robot
Fix to return negative error code -ENOMEM from the ioremap() error handling
case instead of 0, as done elsewhere in this function.
Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/ipack/carriers/tpci200.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ipack/carriers/tpci200.c b/drivers/ipack/carriers/tpci200.c
index 8a9c169..b5eec18 100644
--- a/drivers/ipack/carriers/tpci200.c
+++ b/drivers/ipack/carriers/tpci200.c
@@ -309,6 +309,7 @@ static int tpci200_register(struct tpci200_board *tpci200)
"(bn 0x%X, sn 0x%X) failed to map driver user space!",
tpci200->info->pdev->bus->number,
tpci200->info->pdev->devfn);
+ res = -ENOMEM;
goto out_release_mem8_space;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] ipack: tpci200: fix error return code in tpci200_register()
2020-05-07 9:42 [PATCH -next] ipack: tpci200: fix error return code in tpci200_register() Wei Yongjun
@ 2020-05-07 14:34 ` Samuel Iglesias Gonsálvez
2020-05-15 14:23 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Iglesias Gonsálvez @ 2020-05-07 14:34 UTC (permalink / raw)
To: Wei Yongjun, Jens Taprogge, Greg Kroah-Hartman, Zhouyang Jia, Kees Cook
Cc: industrypack-devel, linux-kernel, kernel-janitors, Hulk Robot
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
Hello Wei,
Thanks for the patch!
Patch is,
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Greg, Would you mind picking this patch series through your char-misc
tree?
Thanks!
Sam
On Thu, 2020-05-07 at 09:42 +0000, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the ioremap() error
> handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/ipack/carriers/tpci200.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ipack/carriers/tpci200.c
> b/drivers/ipack/carriers/tpci200.c
> index 8a9c169..b5eec18 100644
> --- a/drivers/ipack/carriers/tpci200.c
> +++ b/drivers/ipack/carriers/tpci200.c
> @@ -309,6 +309,7 @@ static int tpci200_register(struct tpci200_board
> *tpci200)
> "(bn 0x%X, sn 0x%X) failed to map driver user
> space!",
> tpci200->info->pdev->bus->number,
> tpci200->info->pdev->devfn);
> + res = -ENOMEM;
> goto out_release_mem8_space;
> }
>
>
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] ipack: tpci200: fix error return code in tpci200_register()
2020-05-07 14:34 ` Samuel Iglesias Gonsálvez
@ 2020-05-15 14:23 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-15 14:23 UTC (permalink / raw)
To: Samuel Iglesias Gonsálvez
Cc: Wei Yongjun, Jens Taprogge, Zhouyang Jia, Kees Cook,
industrypack-devel, linux-kernel, kernel-janitors, Hulk Robot
On Thu, May 07, 2020 at 04:34:06PM +0200, Samuel Iglesias Gonsálvez wrote:
> Hello Wei,
>
> Thanks for the patch!
>
> Patch is,
>
> Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
>
> Greg, Would you mind picking this patch series through your char-misc
> tree?
Sure, will do.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 9:42 [PATCH -next] ipack: tpci200: fix error return code in tpci200_register() Wei Yongjun
2020-05-07 14:34 ` Samuel Iglesias Gonsálvez
2020-05-15 14:23 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome