From: Arvind Sankar <nivedita@alum.mit.edu>
To: Fangrui Song <maskray@google.com>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
Dmitry Golovin <dima@golovin.in>,
clang-built-linux@googlegroups.com,
Ard Biesheuvel <ardb@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Daniel Kiper <daniel.kiper@oracle.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] x86/boot: Check that there are no runtime relocations
Date: Sun, 24 May 2020 19:57:48 -0400 [thread overview]
Message-ID: <20200524235748.GC280334@rani.riverdale.lan> (raw)
In-Reply-To: <20200524233607.cihnsmxuaqoy7xi4@google.com>
On Sun, May 24, 2020 at 04:36:07PM -0700, Fangrui Song wrote:
>
> `grep -qF .rel.local` from 98f78525371b55ccd1c480207ce10296c72fa340
> may be incorrect.. None of these synthesized dynamic relocation sections is
> called *.rel.local* ...
> (it probably wanted to name .rel.data.rel.ro or .rel.data)
>
>
> Reviewed-by: Fangrui Song <maskray@google.com>
At least from gcc you get .data.rel.local sections if you have, for eg:
struct { void *p; } foo = { .p = &bar };
where bar is defined in the same file. These aren't relocation sections,
foo is actually placed in the .data.rel.local section instead of .data.
But yeah, it's incomplete, you wouldn't catch it if bar was external
(foo goes in .data.rel) or foo was const (foo goes in .data.rel.ro*).
next prev parent reply other threads:[~2020-05-24 23:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 8:42 [PATCH] x86/boot: allow a relocatable kernel to be linked with lld Dmitry Golovin
2020-05-02 3:43 ` Nathan Chancellor
2020-05-15 18:50 ` Borislav Petkov
[not found] ` <602331589572661@mail.yandex.ru>
2020-05-17 19:44 ` Fangrui Song
2020-05-17 20:25 ` Arvind Sankar
2020-05-18 19:10 ` Nick Desaulniers
2020-05-24 21:28 ` [PATCH 0/4] x86/boot: Remove runtime relocations from compressed kernel Arvind Sankar
2020-05-25 7:10 ` Ard Biesheuvel
2020-05-25 22:59 ` [PATCH v2 " Arvind Sankar
2020-05-26 12:29 ` Sedat Dilek
2020-05-26 12:30 ` Ard Biesheuvel
2020-05-26 12:33 ` Sedat Dilek
2020-05-26 12:44 ` Sedat Dilek
2020-05-26 14:47 ` Arvind Sankar
2020-05-26 14:50 ` Sedat Dilek
2020-05-26 15:36 ` Arvind Sankar
2020-05-26 15:38 ` Sedat Dilek
2020-05-27 6:26 ` Sedat Dilek
2020-05-26 14:48 ` Sedat Dilek
2020-05-26 14:55 ` Sedat Dilek
2020-05-26 15:07 ` Sedat Dilek
2020-05-26 15:31 ` Arvind Sankar
2020-05-27 6:24 ` Sedat Dilek
2020-05-26 16:18 ` Sedat Dilek
2020-05-25 22:59 ` [PATCH v2 1/4] x86/boot: Add .text.* to setup.ld Arvind Sankar
2020-05-25 22:59 ` [PATCH v2 2/4] x86/boot: Remove run-time relocations from .head.text code Arvind Sankar
2020-05-25 22:59 ` [PATCH v2 3/4] x86/boot: Remove runtime relocations from head_{32,64}.S Arvind Sankar
2020-05-25 22:59 ` [PATCH v2 4/4] x86/boot: Check that there are no runtime relocations Arvind Sankar
2020-05-26 6:11 ` Ard Biesheuvel
2020-05-26 15:16 ` Arvind Sankar
2020-05-26 17:13 ` Fangrui Song
2020-05-26 19:14 ` Arvind Sankar
2020-08-06 11:19 ` Andy Shevchenko
2020-08-06 16:12 ` Arvind Sankar
2020-05-26 0:37 ` [PATCH 0/4] x86/boot: Remove runtime relocations from compressed kernel Fangrui Song
2020-05-24 21:28 ` [PATCH 1/4] x86/boot: Add .text.startup to setup.ld Arvind Sankar
2020-05-24 22:13 ` Fangrui Song
2020-05-24 23:00 ` Arvind Sankar
2020-05-24 23:49 ` Fangrui Song
2020-05-24 22:48 ` Brian Gerst
2020-05-24 21:28 ` [PATCH 2/4] x86/boot: Remove runtime relocations from .head.text code Arvind Sankar
2020-05-24 22:53 ` Fangrui Song
2020-05-24 23:44 ` Arvind Sankar
2020-05-25 0:55 ` Fangrui Song
2020-05-24 21:28 ` [PATCH 3/4] x86/boot: Remove runtime relocations from head_{32,64}.S Arvind Sankar
2020-05-24 23:22 ` Fangrui Song
2020-05-24 23:58 ` Arvind Sankar
2020-05-24 21:28 ` [PATCH 4/4] x86/boot: Check that there are no runtime relocations Arvind Sankar
2020-05-24 23:36 ` Fangrui Song
2020-05-24 23:57 ` Arvind Sankar [this message]
2020-05-25 6:10 ` Ard Biesheuvel
2020-05-25 16:26 ` Fangrui Song
2020-05-25 19:22 ` Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524235748.GC280334@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel.kiper@oracle.com \
--cc=dima@golovin.in \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®