From: Vladimir Oltean <olteanv@gmail.com>
To: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org
Cc: jslaby@suse.com, andriy.shevchenko@linux.intel.com,
lukas@wunner.de, heikki.krogerus@linux.intel.com,
vigneshr@ti.com, linux-kernel@vger.kernel.org, fido_max@inbox.ru,
radu-andrei.bulie@nxp.com
Subject: [PATCH] serial: 8250: probe all 16550A variants by default
Date: Mon, 25 May 2020 16:02:38 +0300 [thread overview]
Message-ID: <20200525130238.3614179-1-olteanv@gmail.com> (raw)
From: Vladimir Oltean <vladimir.oltean@nxp.com>
On NXP T1040, the UART is typically detected as 16550A_FSL64. After said
patch, it gets detected as plain 16550A and the Linux console is
completely garbled and missing characters.
So clearly, introducing the SERIAL_8250_16550A_VARIANTS config option
has broken many existing users because it has changed the default
behavior. Restore that by adding a 'default y' to this option. Users who
care about 20 ms shorter boot time can always disable it, but stop
wasting many debugging hours for people who don't care all that much.
Fixes: dc56ecb81a0a ("serial: 8250: Support disabling mdelay-filled probes of 16550A variants")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/tty/serial/8250/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index af0688156dd0..89c7ecb55619 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -63,6 +63,7 @@ config SERIAL_8250_PNP
config SERIAL_8250_16550A_VARIANTS
bool "Support for variants of the 16550A serial port"
depends on SERIAL_8250
+ default y
help
The 8250 driver can probe for many variants of the venerable 16550A
serial port. Doing so takes additional time at boot.
--
2.25.1
next reply other threads:[~2020-05-25 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 13:02 Vladimir Oltean [this message]
2020-05-25 13:40 ` Andy Shevchenko
2020-05-25 17:28 ` Josh Triplett
2020-05-25 18:52 ` Vladimir Oltean
2020-05-25 20:48 ` Josh Triplett
2020-05-26 7:05 ` Maxim Kochetkov
2020-05-26 8:35 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525130238.3614179-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fido_max@inbox.ru \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=radu-andrei.bulie@nxp.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome