mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxim Kochetkov <fido_max@inbox.ru>
To: Josh Triplett <josh@joshtriplett.org>,
	Vladimir Oltean <olteanv@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
	jslaby@suse.com, andriy.shevchenko@linux.intel.com,
	lukas@wunner.de, heikki.krogerus@linux.intel.com,
	vigneshr@ti.com, linux-kernel@vger.kernel.org,
	radu-andrei.bulie@nxp.com
Subject: Re: [PATCH] serial: 8250: probe all 16550A variants by default
Date: Tue, 26 May 2020 10:05:25 +0300	[thread overview]
Message-ID: <d989c5fe-451d-e6b4-a2f1-f6330809af99@inbox.ru> (raw)
In-Reply-To: <20200525172815.GA445190@localhost>

This change breaks all my devices: OMAP-L138 (davinci based), LS1021A, 
T1040, Marvell (kirkwood2 based). Only enabling VARIANTS on all my 
devices fix the issue.

25.05.2020 20:28, Josh Triplett wrote:
> On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote:
>> On NXP T1040, the UART is typically detected as 16550A_FSL64. After said
>> patch, it gets detected as plain 16550A and the Linux console is
>> completely garbled and missing characters.
> Interesting that there's*new*  powerpc hardware that needs these
> variants. I based the patch on the fact that, on x86 at least, hardware
> using these variants hasn't been made for a long time.

  parent reply	other threads:[~2020-05-26  7:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 13:02 Vladimir Oltean
2020-05-25 13:40 ` Andy Shevchenko
2020-05-25 17:28 ` Josh Triplett
2020-05-25 18:52   ` Vladimir Oltean
2020-05-25 20:48     ` Josh Triplett
2020-05-26  7:05   ` Maxim Kochetkov [this message]
2020-05-26  8:35     ` Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d989c5fe-451d-e6b4-a2f1-f6330809af99@inbox.ru \
    --to=fido_max@inbox.ru \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=josh@joshtriplett.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=olteanv@gmail.com \
    --cc=radu-andrei.bulie@nxp.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®