* [PATCH 13/15] aquantia: atlantic: use PCI_IRQ_ALL_TYPES where appropriate
@ 2020-06-02 9:21 Piotr Stankiewicz
2020-06-02 22:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Piotr Stankiewicz @ 2020-06-02 9:21 UTC (permalink / raw)
To: Igor Russkikh, David S . Miller, Jakub Kicinski
Cc: netdev, linux-kernel, Piotr Stankiewicz
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
index 8a70ffe1d326..2a0ebf296478 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -277,9 +277,7 @@ static int aq_pci_probe(struct pci_dev *pdev,
numvecs += AQ_HW_SERVICE_IRQS;
/*enable interrupts */
#if !AQ_CFG_FORCE_LEGACY_INT
- err = pci_alloc_irq_vectors(self->pdev, 1, numvecs,
- PCI_IRQ_MSIX | PCI_IRQ_MSI |
- PCI_IRQ_LEGACY);
+ err = pci_alloc_irq_vectors(self->pdev, 1, numvecs, PCI_IRQ_ALL_TYPES);
if (err < 0)
goto err_hwinit;
--
2.17.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 13/15] aquantia: atlantic: use PCI_IRQ_ALL_TYPES where appropriate
2020-06-02 9:21 [PATCH 13/15] aquantia: atlantic: use PCI_IRQ_ALL_TYPES where appropriate Piotr Stankiewicz
@ 2020-06-02 22:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-02 22:27 UTC (permalink / raw)
To: piotr.stankiewicz; +Cc: irusskikh, kuba, netdev, linux-kernel
From: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Date: Tue, 2 Jun 2020 11:21:11 +0200
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-02 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 9:21 [PATCH 13/15] aquantia: atlantic: use PCI_IRQ_ALL_TYPES where appropriate Piotr Stankiewicz
2020-06-02 22:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®