* [PATCH] net: stmmac: Drop condition with no effect
@ 2020-06-02 10:44 Aishwarya Ramakrishnan
2020-06-02 22:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Aishwarya Ramakrishnan @ 2020-06-02 10:44 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
David S. Miller, Jakub Kicinski, Maxime Coquelin, netdev,
linux-stm32, linux-arm-kernel, linux-kernel
Cc: aishwaryarj100
As the "else if" and "else" branch body are identical the
condition has no effect. So removing "else if" condition.
Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index bcda49dcf619..f59813a0405c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -229,8 +229,6 @@ static int stmmac_mtl_setup(struct platform_device *pdev,
plat->tx_sched_algorithm = MTL_TX_ALGORITHM_WFQ;
else if (of_property_read_bool(tx_node, "snps,tx-sched-dwrr"))
plat->tx_sched_algorithm = MTL_TX_ALGORITHM_DWRR;
- else if (of_property_read_bool(tx_node, "snps,tx-sched-sp"))
- plat->tx_sched_algorithm = MTL_TX_ALGORITHM_SP;
else
plat->tx_sched_algorithm = MTL_TX_ALGORITHM_SP;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: stmmac: Drop condition with no effect
2020-06-02 10:44 [PATCH] net: stmmac: Drop condition with no effect Aishwarya Ramakrishnan
@ 2020-06-02 22:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-02 22:28 UTC (permalink / raw)
To: aishwaryarj100
Cc: peppe.cavallaro, alexandre.torgue, joabreu, kuba,
mcoquelin.stm32, netdev, linux-stm32, linux-arm-kernel,
linux-kernel
From: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
Date: Tue, 2 Jun 2020 16:14:04 +0530
> As the "else if" and "else" branch body are identical the
> condition has no effect. So removing "else if" condition.
>
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
I'm not applying these patches, the conditional tests serve as
documentation.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-02 22:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 10:44 [PATCH] net: stmmac: Drop condition with no effect Aishwarya Ramakrishnan
2020-06-02 22:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®