From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Chuhong Yuan <hslester96@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ilkka Myllyperkio <ilkka.myllyperkio@sofica.fi>,
"Ivan T . Ivanov" <iivanov@mm-sol.com>,
Vimarsh Zutshi <vimarsh.zutshi@gmail.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: omap3isp: Add missed v4l2_ctrl_handler_free() for preview_init_entities()
Date: Thu, 4 Jun 2020 12:50:26 +0300 [thread overview]
Message-ID: <20200604095026.GI9947@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20200604093321.GE5829@pendragon.ideasonboard.com>
On Thu, Jun 04, 2020 at 12:33:21PM +0300, Laurent Pinchart wrote:
> Hi Chuhong,
>
> (CC'ing Sakari Ailus)
>
> Thank you for the patch.
>
> On Thu, Jun 04, 2020 at 12:41:22AM +0800, Chuhong Yuan wrote:
> > preview_init_entities() does not call v4l2_ctrl_handler_free() when
> > it fails.
> > Add the missed function to fix it.
> >
> > Fixes: de1135d44f4f ("[media] omap3isp: CCDC, preview engine and resizer]")
>
> There's an extra ']' at the end. Apart from that,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Sakari, could you take this patch ?
Done; thank you!
--
Sakari Ailus
prev parent reply other threads:[~2020-06-04 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 16:41 Chuhong Yuan
2020-06-04 9:33 ` Laurent Pinchart
2020-06-04 9:50 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604095026.GI9947@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hslester96@gmail.com \
--cc=iivanov@mm-sol.com \
--cc=ilkka.myllyperkio@sofica.fi \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vimarsh.zutshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®