mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] yam: fix possible memory leak in yam_init_driver
@ 2020-06-04 12:18 Wang Hai
  2020-06-04 22:58 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-06-04 12:18 UTC (permalink / raw)
  To: jpr, davem, kuba; +Cc: linux-hams, netdev, linux-kernel, wanghai38

If register_netdev(dev) fails, free_netdev(dev) needs
to be called, otherwise a memory leak will occur.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/net/hamradio/yam.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 71cdef9..5ab53e9 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -1133,6 +1133,7 @@ static int __init yam_init_driver(void)
 		err = register_netdev(dev);
 		if (err) {
 			printk(KERN_WARNING "yam: cannot register net device %s\n", dev->name);
+			free_netdev(dev);
 			goto error;
 		}
 		yam_devs[i] = dev;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] yam: fix possible memory leak in yam_init_driver
  2020-06-04 12:18 [PATCH] yam: fix possible memory leak in yam_init_driver Wang Hai
@ 2020-06-04 22:58 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-04 22:58 UTC (permalink / raw)
  To: wanghai38; +Cc: jpr, kuba, linux-hams, netdev, linux-kernel

From: Wang Hai <wanghai38@huawei.com>
Date: Thu, 4 Jun 2020 20:18:51 +0800

> If register_netdev(dev) fails, free_netdev(dev) needs
> to be called, otherwise a memory leak will occur.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-04 22:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 12:18 [PATCH] yam: fix possible memory leak in yam_init_driver Wang Hai
2020-06-04 22:58 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®