From: David Miller <davem@davemloft.net>
To: wang.yi59@zte.com.cn
Cc: kuba@kernel.org, mst@redhat.com, hkallweit1@gmail.com,
snelson@pensando.io, andriy.shevchenko@linux.intel.com,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
wang.liang82@zte.com.cn, liao.pingfang@zte.com.cn
Subject: Re: [PATCH v2] net: atm: Remove the error message according to the atomic context
Date: Wed, 10 Jun 2020 18:08:26 -0700 (PDT) [thread overview]
Message-ID: <20200610.180826.499189657042137494.davem@davemloft.net> (raw)
In-Reply-To: <1591835930-25941-1-git-send-email-wang.yi59@zte.com.cn>
From: Yi Wang <wang.yi59@zte.com.cn>
Date: Thu, 11 Jun 2020 08:38:50 +0800
> @@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
>
> to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
> if (!to_return) {
> - pr_info("LEC: Arp entry kmalloc failed\n");
> return NULL;
> }
This now becomes a single-statement basic block and thus the curly
braces should be removed.
prev parent reply other threads:[~2020-06-11 1:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 0:38 Yi Wang
2020-06-11 1:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610.180826.499189657042137494.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xiyou.wangcong@gmail.com \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®