From: Sakari Ailus <sakari.ailus@iki.fi>
To: Andrey Konovalov <andrey.konovalov@linaro.org>
Cc: mchehab@kernel.org, manivannan.sadhasivam@linaro.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
c.barrett@framos.com, a.brela@framos.com,
peter.griffin@linaro.org
Subject: Re: [PATCH v4 00/10] Improvements to IMX290 CMOS driver
Date: Thu, 11 Jun 2020 02:55:10 +0300 [thread overview]
Message-ID: <20200610235510.GC805@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20200607163025.8409-1-andrey.konovalov@linaro.org>
Hi Andrey,
On Sun, Jun 07, 2020 at 07:30:15PM +0300, Andrey Konovalov wrote:
> This patchset adds improvements to the existing media driver for IMX290
> CMOS sensor from Sony. The major changes are adding 2 lane support,
> configurable link frequency & pixel rate, test pattern generation, and
> RAW12 mode support.
Could you still see what checkpatch.pl says and address the style issues,
please? Apart from those this seems fine to me.
There are some on msleep() but I wouldn't worry about those.
Thanks.
--
Sakari Ailus
prev parent reply other threads:[~2020-06-10 23:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 16:30 Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 01/10] media: i2c: imx290: set the format before VIDIOC_SUBDEV_G_FMT is called Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 02/10] media: i2c: imx290: fix the order of the args in SET_RUNTIME_PM_OPS() Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 03/10] media: i2c: imx290: fix reset GPIO pin handling Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 04/10] media: i2c: imx290: Add support for 2 data lanes Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 05/10] media: i2c: imx290: Add configurable link frequency and pixel rate Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 06/10] media: i2c: imx290: Add support for test pattern generation Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 07/10] media: i2c: imx290: Add RAW12 mode support Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 08/10] media: i2c: imx290: Add support to enumerate all frame sizes Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 09/10] media: i2c: imx290: Move the settle time delay out of loop Andrey Konovalov
2020-06-07 16:30 ` [PATCH v4 10/10] media: i2c: imx290: set bus_type before calling v4l2_fwnode_endpoint_alloc_parse() Andrey Konovalov
2020-06-10 23:55 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610235510.GC805@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=a.brela@framos.com \
--cc=andrey.konovalov@linaro.org \
--cc=c.barrett@framos.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®