* [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function
@ 2020-06-16 9:51 Stanley Chu
2020-06-16 12:38 ` Avri Altman
2020-06-20 3:26 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Stanley Chu @ 2020-06-16 9:51 UTC (permalink / raw)
To: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb, asutoshd
Cc: beanhuo, cang, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, cc.chou, chaotian.jing, Stanley Chu
Fix build warning reported by kernel test robot:
Make ufs_mtk_wait_link_state() as static functon.
Warning:
>> drivers/scsi/ufs/ufs-mediatek.c:181:5: warning: no previous prototype
>> for 'ufs_mtk_wait_link_state' [-Wmissing-prototypes]
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 9a4432c9f7dc..ad929235c193 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -185,8 +185,8 @@ static void ufs_mtk_setup_ref_clk_wait_us(struct ufs_hba *hba,
host->ref_clk_ungating_wait_us = ungating_us;
}
-int ufs_mtk_wait_link_state(struct ufs_hba *hba, u32 state,
- unsigned long max_wait_ms)
+static int ufs_mtk_wait_link_state(struct ufs_hba *hba, u32 state,
+ unsigned long max_wait_ms)
{
ktime_t timeout, time_checked;
u32 val;
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function
2020-06-16 9:51 [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function Stanley Chu
@ 2020-06-16 12:38 ` Avri Altman
2020-06-20 3:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2020-06-16 12:38 UTC (permalink / raw)
To: Stanley Chu, linux-scsi, martin.petersen, alim.akhtar, jejb, asutoshd
Cc: beanhuo, cang, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, cc.chou, chaotian.jing
>
> Fix build warning reported by kernel test robot:
> Make ufs_mtk_wait_link_state() as static functon.
>
> Warning:
> >> drivers/scsi/ufs/ufs-mediatek.c:181:5: warning: no previous prototype
> >> for 'ufs_mtk_wait_link_state' [-Wmissing-prototypes]
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function
2020-06-16 9:51 [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function Stanley Chu
2020-06-16 12:38 ` Avri Altman
@ 2020-06-20 3:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-06-20 3:26 UTC (permalink / raw)
To: alim.akhtar, Stanley Chu, jejb, avri.altman, linux-scsi, asutoshd
Cc: Martin K . Petersen, bvanassche, kuohong.wang, chun-hung.wu,
chaotian.jing, matthias.bgg, linux-arm-kernel, peter.wang,
cc.chou, andy.teng, linux-mediatek, beanhuo, linux-kernel, cang
On Tue, 16 Jun 2020 17:51:20 +0800, Stanley Chu wrote:
> Fix build warning reported by kernel test robot:
> Make ufs_mtk_wait_link_state() as static functon.
>
> Warning:
> >> drivers/scsi/ufs/ufs-mediatek.c:181:5: warning: no previous prototype
> >> for 'ufs_mtk_wait_link_state' [-Wmissing-prototypes]
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state static
https://git.kernel.org/mkp/scsi/c/9a3cd470f8e3
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-20 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 9:51 [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function Stanley Chu
2020-06-16 12:38 ` Avri Altman
2020-06-20 3:26 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®