From: Pengfei Xu <pengfei.xu@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Shuah Khan <shuah@kernel.org>, Heng Su <heng.su@intel.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Kai Svahn <kai.svahn@intel.com>
Subject: Re: [Linux] [PATCH] Kernel selftests: tpm2: upgrade tpm2 tests from python2 to python3
Date: Thu, 18 Jun 2020 15:51:04 +0800 [thread overview]
Message-ID: <20200618075104.GA13935@xpf-desktop.sh.intel.com> (raw)
In-Reply-To: <20200618071858.GD6560@linux.intel.com>
Hi Jarkko,
Thanks for your advice.
My feedback is as below.
BR.
Thanks!
On 2020-06-18 at 10:18:58 +0300, Jarkko Sakkinen wrote:
> On Thu, Jun 18, 2020 at 11:02:45AM +0800, Pengfei Xu wrote:
> > Some Linux OS will never support python2 anymore, so upgrade tpm2 selftests
> > to python3.
> >
> > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>
>
> Linux is a kernel, not a full operating system. Perhaps you mean Linux
> distributions?
>
Will remove [Linux], thanks!
> Please capitalize abbrevations correctly (TPM2, not tpm2). Please write
> 'Python 2' instead of python2.
>
Will do, thanks!
> With that said the commit message is inaccurate. The root reason for
> moving to Python 3 is that Python 2 is no longer supported by the Python
> upstream project. Nothing to do with Linux or Linux distributions for
> that matter.
>
Will do, thanks!
> /Jarkko
next prev parent reply other threads:[~2020-06-18 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 3:02 Pengfei Xu
2020-06-18 7:18 ` Jarkko Sakkinen
2020-06-18 7:51 ` Pengfei Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-17 3:47 Pengfei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618075104.GA13935@xpf-desktop.sh.intel.com \
--to=pengfei.xu@intel.com \
--cc=heng.su@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kai.svahn@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®