From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Colin King <colin.king@canonical.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret
Date: Thu, 18 Jun 2020 20:44:11 +1000 [thread overview]
Message-ID: <20200618104411.GA10882@gondor.apana.org.au> (raw)
In-Reply-To: <5452e045-bd48-3b29-b364-bf123540ae21@nxp.com>
On Thu, Jun 18, 2020 at 01:40:55PM +0300, Horia Geantă wrote:
> On 6/18/2020 10:58 AM, Herbert Xu wrote:
> > On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> The variable ret is being assigned a value that is never read, the
> >> error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning
> >> ret with -ENOMEM is redundamt.
> >>
> >> Addresses-Coverity: ("Unused value")
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >> ---
> >> drivers/crypto/caam/caamalg_qi2.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >
> > Patch applied. Thanks.
> >
> Unfortunately I missed this patch, and it doesn't look correct.
>
> Do I need to send a revert?
No please check again. The patch is correct.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-06-18 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 15:39 Colin King
2020-06-18 7:58 ` Herbert Xu
2020-06-18 10:40 ` Horia Geantă
2020-06-18 10:44 ` Herbert Xu [this message]
2020-06-18 10:54 ` Horia Geantă
2020-06-18 11:00 ` Herbert Xu
2020-06-18 13:16 ` Horia Geantă
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618104411.GA10882@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=aymen.sghaier@nxp.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®