mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Horia Geantă" <horia.geanta@nxp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Colin King <colin.king@canonical.com>,
	Aymen Sghaier <aymen.sghaier@nxp.com>,
	"David S . Miller" <davem@davemloft.net>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret
Date: Thu, 18 Jun 2020 16:16:29 +0300	[thread overview]
Message-ID: <b351f9b5-940c-61d3-38f2-3654c6da55b0@nxp.com> (raw)
In-Reply-To: <20200618110050.GA10995@gondor.apana.org.au>

On 6/18/2020 2:00 PM, Herbert Xu wrote:
> On Thu, Jun 18, 2020 at 01:54:55PM +0300, Horia Geantă wrote:
>>
>> The proper fix would be updating the ahash_finup_no_ctx() function
>> to return the specific error code:
>> 	return ret;
>> instead of returning -ENOMEM for all error cases.
>>
>> For example error code returned by dpaa2_caam_enqueue()
>> should be returned instead of -ENOMEM.
> 
> You can do that as a follow-up.  The patch is correct as is.
> 
Just that the follow-up implies adding all the code back.

Anyway, not a big deal...

Thanks,
Horia

      reply	other threads:[~2020-06-18 13:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 15:39 Colin King
2020-06-18  7:58 ` Herbert Xu
2020-06-18 10:40   ` Horia Geantă
2020-06-18 10:44     ` Herbert Xu
2020-06-18 10:54 ` Horia Geantă
2020-06-18 11:00   ` Herbert Xu
2020-06-18 13:16     ` Horia Geantă [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b351f9b5-940c-61d3-38f2-3654c6da55b0@nxp.com \
    --to=horia.geanta@nxp.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®