* drivers/clk/clk-divider.c:39:17: sparse: sparse: incorrect type in argument 1 (different base types)
@ 2020-06-21 9:05 kernel test robot
2020-06-22 8:36 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-06-21 9:05 UTC (permalink / raw)
To: Stephen Boyd; +Cc: kbuild-all, linux-kernel, Mark Brown, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 10219 bytes --]
Hi Stephen,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 64677779e8962c20b580b471790fe42367750599
commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
date: 7 weeks ago
config: alpha-randconfig-s032-20200621 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-rc2-13-gc59158c8-dirty
git checkout bbd7ffdbef6888459f301c5889f3b14ada38b913
# save the attached .config to linux build tree
make W=1 C=1 ARCH=alpha CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
>> drivers/clk/clk-divider.c:39:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] @@ got restricted __be32 [usertype] @@
>> drivers/clk/clk-divider.c:39:17: sparse: expected unsigned int [usertype]
drivers/clk/clk-divider.c:39:17: sparse: got restricted __be32 [usertype]
--
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
>> drivers/clk/clk-gate.c:37:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] @@ got restricted __be32 [usertype] @@
>> drivers/clk/clk-gate.c:37:17: sparse: expected unsigned int [usertype]
drivers/clk/clk-gate.c:37:17: sparse: got restricted __be32 [usertype]
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-gate.c:29:24: sparse: sparse: cast to restricted __be32
--
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-multiplier.c:18:24: sparse: sparse: cast to restricted __be32
>> drivers/clk/clk-multiplier.c:26:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] @@ got restricted __be32 [usertype] @@
>> drivers/clk/clk-multiplier.c:26:17: sparse: expected unsigned int [usertype]
drivers/clk/clk-multiplier.c:26:17: sparse: got restricted __be32 [usertype]
--
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-mux.c:29:24: sparse: sparse: cast to restricted __be32
>> drivers/clk/clk-mux.c:37:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] @@ got restricted __be32 [usertype] @@
>> drivers/clk/clk-mux.c:37:17: sparse: expected unsigned int [usertype]
drivers/clk/clk-mux.c:37:17: sparse: got restricted __be32 [usertype]
--
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
drivers/clk/clk-fractional-divider.c:20:24: sparse: sparse: cast to restricted __be32
>> drivers/clk/clk-fractional-divider.c:28:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] @@ got restricted __be32 [usertype] @@
>> drivers/clk/clk-fractional-divider.c:28:17: sparse: expected unsigned int [usertype]
drivers/clk/clk-fractional-divider.c:28:17: sparse: got restricted __be32 [usertype]
vim +39 drivers/clk/clk-divider.c
9d9f78ed9af0e4 Mike Turquette 2012-03-15 17
9d9f78ed9af0e4 Mike Turquette 2012-03-15 18 /*
9d9f78ed9af0e4 Mike Turquette 2012-03-15 19 * DOC: basic adjustable divider clock that cannot gate
9d9f78ed9af0e4 Mike Turquette 2012-03-15 20 *
9d9f78ed9af0e4 Mike Turquette 2012-03-15 21 * Traits of this clock:
9d9f78ed9af0e4 Mike Turquette 2012-03-15 22 * prepare - clk_prepare only ensures that parents are prepared
9d9f78ed9af0e4 Mike Turquette 2012-03-15 23 * enable - clk_enable only ensures that parents are enabled
9556f9dad8f576 Brian Norris 2015-04-13 24 * rate - rate is adjustable. clk->rate = ceiling(parent->rate / divisor)
9d9f78ed9af0e4 Mike Turquette 2012-03-15 25 * parent - fixed parent. No clk_set_parent support
9d9f78ed9af0e4 Mike Turquette 2012-03-15 26 */
9d9f78ed9af0e4 Mike Turquette 2012-03-15 27
434d69fad63b44 Jonas Gorski 2019-04-18 28 static inline u32 clk_div_readl(struct clk_divider *divider)
434d69fad63b44 Jonas Gorski 2019-04-18 29 {
434d69fad63b44 Jonas Gorski 2019-04-18 30 if (divider->flags & CLK_DIVIDER_BIG_ENDIAN)
434d69fad63b44 Jonas Gorski 2019-04-18 @31 return ioread32be(divider->reg);
434d69fad63b44 Jonas Gorski 2019-04-18 32
5834fd75e62366 Jonas Gorski 2019-04-18 33 return readl(divider->reg);
434d69fad63b44 Jonas Gorski 2019-04-18 34 }
434d69fad63b44 Jonas Gorski 2019-04-18 35
434d69fad63b44 Jonas Gorski 2019-04-18 36 static inline void clk_div_writel(struct clk_divider *divider, u32 val)
434d69fad63b44 Jonas Gorski 2019-04-18 37 {
434d69fad63b44 Jonas Gorski 2019-04-18 38 if (divider->flags & CLK_DIVIDER_BIG_ENDIAN)
434d69fad63b44 Jonas Gorski 2019-04-18 @39 iowrite32be(val, divider->reg);
434d69fad63b44 Jonas Gorski 2019-04-18 40 else
5834fd75e62366 Jonas Gorski 2019-04-18 41 writel(val, divider->reg);
434d69fad63b44 Jonas Gorski 2019-04-18 42 }
434d69fad63b44 Jonas Gorski 2019-04-18 43
:::::: The code at line 39 was first introduced by commit
:::::: 434d69fad63b443d7afc8aa99264359c9b4e2d3a clk: divider: add explicit big endian support
:::::: TO: Jonas Gorski <jonas.gorski@gmail.com>
:::::: CC: Stephen Boyd <sboyd@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27740 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drivers/clk/clk-divider.c:39:17: sparse: sparse: incorrect type in argument 1 (different base types)
2020-06-21 9:05 drivers/clk/clk-divider.c:39:17: sparse: sparse: incorrect type in argument 1 (different base types) kernel test robot
@ 2020-06-22 8:36 ` Stephen Boyd
2020-06-22 8:42 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-06-22 8:36 UTC (permalink / raw)
To: kernel test robot; +Cc: kbuild-all, linux-kernel, Mark Brown, Arnd Bergmann
Quoting kernel test robot (2020-06-21 02:05:20)
> Hi Stephen,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 64677779e8962c20b580b471790fe42367750599
> commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
> date: 7 weeks ago
> config: alpha-randconfig-s032-20200621 (attached as .config)
> compiler: alpha-linux-gcc (GCC) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.2-rc2-13-gc59158c8-dirty
> git checkout bbd7ffdbef6888459f301c5889f3b14ada38b913
> # save the attached .config to linux build tree
> make W=1 C=1 ARCH=alpha CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> drivers/clk/clk-divider.c:31:24: sparse: sparse: cast to restricted __be32
> >> drivers/clk/clk-divider.c:39:17: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] @@ got restricted __be32 [usertype] @@
> >> drivers/clk/clk-divider.c:39:17: sparse: expected unsigned int [usertype]
> drivers/clk/clk-divider.c:39:17: sparse: got restricted __be32 [usertype]
>
> vim +39 drivers/clk/clk-divider.c
>
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 17
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 18 /*
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 19 * DOC: basic adjustable divider clock that cannot gate
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 20 *
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 21 * Traits of this clock:
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 22 * prepare - clk_prepare only ensures that parents are prepared
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 23 * enable - clk_enable only ensures that parents are enabled
> 9556f9dad8f576 Brian Norris 2015-04-13 24 * rate - rate is adjustable. clk->rate = ceiling(parent->rate / divisor)
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 25 * parent - fixed parent. No clk_set_parent support
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 26 */
> 9d9f78ed9af0e4 Mike Turquette 2012-03-15 27
> 434d69fad63b44 Jonas Gorski 2019-04-18 28 static inline u32 clk_div_readl(struct clk_divider *divider)
> 434d69fad63b44 Jonas Gorski 2019-04-18 29 {
> 434d69fad63b44 Jonas Gorski 2019-04-18 30 if (divider->flags & CLK_DIVIDER_BIG_ENDIAN)
> 434d69fad63b44 Jonas Gorski 2019-04-18 @31 return ioread32be(divider->reg);
Ok. I guess we'll need to force cast the pointer to be __be32 in this
case. Before it wasn't in generic code so the architecture was masking
the issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drivers/clk/clk-divider.c:39:17: sparse: sparse: incorrect type in argument 1 (different base types)
2020-06-22 8:36 ` Stephen Boyd
@ 2020-06-22 8:42 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-06-22 8:42 UTC (permalink / raw)
To: Stephen Boyd; +Cc: kernel test robot, kbuild-all, linux-kernel, Mark Brown
On Mon, Jun 22, 2020 at 10:36 AM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting kernel test robot (2020-06-21 02:05:20)
> > Hi Stephen,
> >
> > First bad commit (maybe != root cause):
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 64677779e8962c20b580b471790fe42367750599
> > commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
> > date: 7 weeks ago
> > config: alpha-randconfig-s032-20200621 (attached as .config)
> > compiler: alpha-linux-gcc (GCC) 9.3.0
> > reproduce:
> > # apt-get install sparse
> > # sparse version: v0.6.2-rc2-13-gc59158c8-dirty
> > git checkout bbd7ffdbef6888459f301c5889f3b14ada38b913
> > # save the attached .config to linux build tree
> > make W=1 C=1 ARCH=alpha CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
>
> Ok. I guess we'll need to force cast the pointer to be __be32 in this
> case. Before it wasn't in generic code so the architecture was masking
> the issue.
I'm fairly sure the problem not in your code, but in the alpha implementation
if ioread32be:
#define ioread16be(p) be16_to_cpu(ioread16(p))
#define ioread32be(p) be32_to_cpu(ioread32(p))
#define iowrite16be(v,p) iowrite16(cpu_to_be16(v), (p))
#define iowrite32be(v,p) iowrite32(cpu_to_be32(v), (p))
This must produce a warning for any call to ioread32be(), you just got the
email because additional warnings showed up now that this code can be
built on alpha as well.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-22 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 9:05 drivers/clk/clk-divider.c:39:17: sparse: sparse: incorrect type in argument 1 (different base types) kernel test robot
2020-06-22 8:36 ` Stephen Boyd
2020-06-22 8:42 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®